Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/wafv2_web_acl and wafv2_rule_group: support for IPSetForwardedIPConfig in IPSetReferenceStatement #14902

Merged
merged 1 commit into from
Aug 31, 2020
Merged

resource/wafv2_web_acl and wafv2_rule_group: support for IPSetForwardedIPConfig in IPSetReferenceStatement #14902

merged 1 commit into from
Aug 31, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Aug 28, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14465

Release note for CHANGELOG:

resource/wafv2_web_acl: support for IPSetForwardedIPConfig in IPSetReferenceStatement
resource/wafv2_rule_group: support for IPSetForwardedIPConfig in IPSetReferenceStatement

Output from acceptance testing:

--- PASS: TestAccAwsWafv2RuleGroup_IpSetReferenceStatement (33.56s)
--- PASS: TestAccAwsWafv2RuleGroup_IpSetReferenceStatement_IPSetForwardedIPConfig (97.89s)
--- PASS: TestAccAwsWafv2WebACL_IPSetReferenceStatement (266.13s)
--- PASS: TestAccAwsWafv2WebACL_IPSetReferenceStatement_IPSetForwardedIPConfig (928.37s)

@anGie44 anGie44 requested a review from a team August 28, 2020 21:51
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Aug 28, 2020
@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 28, 2020
bflad
bflad approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Output from acceptance testing:

--- PASS: TestAccAwsWafv2RuleGroup_basic (294.96s)
--- PASS: TestAccAwsWafv2RuleGroup_ByteMatchStatement (725.27s)
--- PASS: TestAccAwsWafv2RuleGroup_ByteMatchStatement_FieldToMatch (2395.54s)
--- PASS: TestAccAwsWafv2RuleGroup_ChangeCapacityForceNew (543.67s)
--- PASS: TestAccAwsWafv2RuleGroup_ChangeMetricNameForceNew (519.62s)
--- PASS: TestAccAwsWafv2RuleGroup_ChangeNameForceNew (548.07s)
--- PASS: TestAccAwsWafv2RuleGroup_Disappears (221.21s)
--- PASS: TestAccAwsWafv2RuleGroup_GeoMatchStatement (718.16s)
--- PASS: TestAccAwsWafv2RuleGroup_GeoMatchStatement_ForwardedIPConfig (732.83s)
--- PASS: TestAccAwsWafv2RuleGroup_IpSetReferenceStatement (377.58s)
--- PASS: TestAccAwsWafv2RuleGroup_IpSetReferenceStatement_IPSetForwardedIPConfig (1406.62s)
--- PASS: TestAccAwsWafv2RuleGroup_LogicalRuleStatements (1086.76s)
--- PASS: TestAccAwsWafv2RuleGroup_Minimal (265.75s)
--- PASS: TestAccAwsWafv2RuleGroup_RegexPatternSetReferenceStatement (389.11s)
--- PASS: TestAccAwsWafv2RuleGroup_RuleAction (1044.10s)
--- PASS: TestAccAwsWafv2RuleGroup_SizeConstraintStatement (716.32s)
--- PASS: TestAccAwsWafv2RuleGroup_SqliMatchStatement (711.91s)
--- PASS: TestAccAwsWafv2RuleGroup_Tags (798.26s)
--- PASS: TestAccAwsWafv2RuleGroup_updateRule (663.15s)
--- PASS: TestAccAwsWafv2RuleGroup_updateRuleProperties (1201.73s)
--- PASS: TestAccAwsWafv2RuleGroup_XssMatchStatement (715.14s)

--- PASS: TestAccAwsWafv2WebACL_basic (3493.14s)
--- PASS: TestAccAwsWafv2WebACL_ChangeNameForceNew (6460.52s)
--- PASS: TestAccAwsWafv2WebACL_Disappears (2764.87s)
--- PASS: TestAccAwsWafv2WebACL_GeoMatchStatement (7832.00s)
--- PASS: TestAccAwsWafv2WebACL_GeoMatchStatement_ForwardedIPConfig (7761.10s)
--- PASS: TestAccAwsWafv2WebACL_IPSetReferenceStatement (4844.32s)
--- PASS: TestAccAwsWafv2WebACL_IPSetReferenceStatement_IPSetForwardedIPConfig (8066.33s)
--- PASS: TestAccAwsWafv2WebACL_ManagedRuleGroupStatement (7869.66s)
--- PASS: TestAccAwsWafv2WebACL_MaxNestedOperatorStatements (4103.15s)
--- PASS: TestAccAwsWafv2WebACL_MaxNestedRateBasedStatements (4110.14s)
--- PASS: TestAccAwsWafv2WebACL_Minimal (3397.53s)
--- PASS: TestAccAwsWafv2WebACL_RateBasedStatement (7893.27s)
--- PASS: TestAccAwsWafv2WebACL_RateBasedStatement_ForwardedIPConfig (6056.10s)
--- PASS: TestAccAwsWafv2WebACL_RuleGroupReferenceStatement (6020.54s)
--- PASS: TestAccAwsWafv2WebACL_Tags (5904.43s)
--- PASS: TestAccAwsWafv2WebACL_updateRule (8532.64s)
--- PASS: TestAccAwsWafv2WebACL_UpdateRuleProperties (9566.37s)

@anGie44 anGie44 added this to the v3.5.0 milestone Aug 31, 2020
@anGie44 anGie44 merged commit e752f91 into master Aug 31, 2020
@anGie44 anGie44 deleted the f-ipsetforwardedipconfig-for-ipsetrefstatement branch August 31, 2020 16:55
anGie44 added a commit that referenced this pull request Aug 31, 2020
@anGie44
Update CHANGELOG for #14902
1206283
@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Sep 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.5.0
Development

Successfully merging this pull request may close these issues.

terraform aws waf should support IPSetForwardedIPConfig attribute of IPSetReferenceStatement
2 participants
@anGie44 @bflad