Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support backups in aws_fsx_lustre_file_system #14930

Closed
mtpdt opened this issue Aug 31, 2020 · 3 comments · Fixed by #15299
Closed

Support backups in aws_fsx_lustre_file_system #14930

mtpdt opened this issue Aug 31, 2020 · 3 comments · Fixed by #15299
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Milestone

Comments

@mtpdt
Copy link
Contributor

mtpdt commented Aug 31, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS FSX Lustre provides backups (https://aws.amazon.com/about-aws/whats-new/2020/06/amazon-fsx-lustre-provides-highly-durable-file-system-backups/). To enable them via terraform, we just need to feed through AutomaticBackupRetentionDays and DailyAutomaticBackupStartTime into CreateFileSystemLustreConfiguration in the aws_fsx_lustre_file_system terraform resource.

New or Affected Resource(s)

  • aws_fsx_lustre_file_system

Potential Terraform Configuration

resource "aws_fsx_lustre_file_system" "example" {
  # ... other configuration ...
  automatic_backup_retention_days = 1
  daily_automatic_backup_start_time = "05:00"
}

References

@mtpdt mtpdt added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 31, 2020
@ghost ghost added the service/fsx Issues and PRs that pertain to the fsx service. label Aug 31, 2020
@mtpdt
Copy link
Contributor Author

mtpdt commented Aug 31, 2020

I will work on this, and submit a PR.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 31, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Sep 1, 2020
@breathingdust breathingdust added this to the v3.9.0 milestone Oct 1, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants