Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_cloudfront_realtime_log_config: New resource #14974

Merged
merged 13 commits into from
Feb 11, 2021
Merged

r/aws_cloudfront_realtime_log_config: New resource #14974

merged 13 commits into from
Feb 11, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Sep 2, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes: #14944.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudFrontRealtimeLogConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontRealtimeLogConfig_ -timeout 120m
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_basic
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_basic
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_disappears
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_disappears
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_updates
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_updates
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_basic
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_updates
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_disappears
    resource_aws_cloudfront_realtime_log_config_test.go:118: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_disappears (62.69s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_basic (64.35s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_updates (110.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	110.498s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn\|TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn\|TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners\|TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn\|TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn\|TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners\|TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners
=== PAUSE TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners
=== RUN   TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn
=== PAUSE TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn
=== RUN   TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn
=== PAUSE TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn
=== RUN   TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== PAUSE TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== CONT  TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners
=== CONT  TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== CONT  TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn
=== CONT  TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (205.48s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (206.56s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn (281.89s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn (281.95s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	281.989s

@ewbankkit ewbankkit requested a review from a team September 2, 2020 13:05
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 2, 2020
@ewbankkit ewbankkit force-pushed the f-aws_cloudfront_realtime_log_config-resource branch 6 times, most recently from e18f468 to 272eaf7 Compare September 4, 2020 13:15
@ewbankkit ewbankkit changed the title [WIP] r/aws_cloudfront_realtime_log_config: New resource r/aws_cloudfront_realtime_log_config: New resource Sep 4, 2020
DrFaust92
DrFaust92 approved these changes Sep 4, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers (231.60s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (235.72s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn (583.97s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_basic (96.68s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_disappears (87.32s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_updates (170.19s)

@ken5scal
Copy link
Contributor

ken5scal commented Sep 28, 2020 •
edited
Loading

Can some one review/merge this? We need this functionality

@blakemorgan blakemorgan mentioned this pull request Oct 20, 2020
Merged
@richerve
Copy link

richerve commented Nov 3, 2020 •
edited
Loading

What else is required to merge this? We also depend on this to debug request headers, and that information is not provided by regular logs. @ewbankkit you should be able to merge afaik, as the PR is approved

@acsgh
Copy link

acsgh commented Dec 1, 2020 •
edited
Loading

Hello @ewbankkit, we also need this feature for our ongoings developments. Is there a reason why this PR is not merged?

Many thank!

@CajuCLC
Copy link

CajuCLC commented Dec 10, 2020

Hi folks. Is there an ETA for this PR to be merged?
Thanks.

@spider-network
Copy link

We are also waiting for this merge.

@rajholla
Copy link
Contributor

Hello @ewbankkit,
We are also looking forward to use this feature.

@seanturner026 seanturner026 mentioned this pull request Jan 15, 2021
Closed
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@ewbankkit
r/aws_cloudfront_realtime_log_config: New resource.
7e60f5e 
Acceptance testing output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudFrontRealtimeLogConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontRealtimeLogConfig_ -timeout 120m
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_basic
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_basic
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_disappears
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_disappears
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_updates
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_updates
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_basic
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_updates
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_disappears
    resource_aws_cloudfront_realtime_log_config_test.go:119: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_disappears (62.40s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_basic (65.18s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_updates (111.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	111.823s
@ewbankkit
r/aws_cloudfront_distribution: Add 'realtime_log_config_arn' attributes.
53b1844
@ewbankkit
r/aws_cloudfront_realtime_log_config: Change 'endpoint' from TypeSet …
4664fd6 
…to TypeList as it has only 1 element. Fixes awsproviderlint S018.
@ewbankkit
Add CHANGELOG entries.
d56952a
@ewbankkit ewbankkit force-pushed the f-aws_cloudfront_realtime_log_config-resource branch from 272eaf7 to d56952a Compare February 6, 2021 22:39
@ewbankkit
Copy link
Contributor Author

Rebase to fix merge conflicts.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudFrontRealtimeLogConfig_\|TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn\|TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn\|TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners\|TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontRealtimeLogConfig_\|TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn\|TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn\|TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners\|TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners
=== PAUSE TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners
=== RUN   TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn
=== PAUSE TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn
=== RUN   TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn
=== PAUSE TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn
=== RUN   TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== PAUSE TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_basic
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_basic
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_disappears
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_disappears
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_updates
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_updates
=== CONT  TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_updates
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_disappears
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_basic
=== CONT  TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames
=== CONT  TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn
=== CONT  TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_disappears (62.91s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_basic (64.22s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_updates (107.78s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (182.38s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (184.36s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn (212.25s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn (212.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	212.944s

@anGie44 anGie44 self-assigned this Feb 11, 2021
@anGie44 anGie44 added the new-resource Introduces a new resource. label Feb 11, 2021
@ewbankkit @anGie44
Update website/docs/r/cloudfront_realtime_log_config.html.markdown
1e55782 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
anGie44
anGie44 approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nitpicks, otherwise LGTM 👍

Output of acceptance tests (commercial):

--- PASS: TestCloudFrontStructure_expandCachedMethods (0.00s)
--- PASS: TestCloudFrontStructure_expandCloudFrontDefaultCacheBehavior (0.00s)
--- PASS: TestCloudFrontStructure_expandLambdaFunctionAssociations (0.00s)
--- PASS: TestCloudFrontStructure_expandHeaders (0.00s)
--- PASS: TestCloudFrontStructure_flattenTrustedSigners (0.00s)
--- PASS: TestCloudFrontStructure_expandlambdaFunctionAssociations_empty (0.00s)
--- PASS: TestCloudFrontStructure_expandForwardedValues (0.00s)
--- PASS: TestCloudFrontStructure_expandTrustedSigners (0.00s)
--- PASS: TestCloudFrontStructure_expandQueryStringCacheKeys (0.00s)
--- PASS: TestCloudFrontStructure_expandAllowedMethods (0.00s)
--- PASS: TestCloudFrontStructure_flattenlambdaFunctionAssociations (0.00s)
--- PASS: TestCloudFrontStructure_expandTrustedSigners_empty (0.00s)
--- PASS: TestCloudFrontStructure_flattenForwardedValues (0.00s)
--- PASS: TestCloudFrontStructure_flattenAllowedMethods (0.00s)
--- PASS: TestCloudFrontStructure_flattenCookieNames (0.00s)
--- PASS: TestCloudFrontStructure_flattenCookiePreference (0.00s)
--- PASS: TestCloudFrontStructure_flattenCachedMethods (0.00s)
--- PASS: TestCloudFrontStructure_expandCookieNames (0.00s)
--- PASS: TestCloudFrontStructure_expandCookiePreference (0.00s)
--- PASS: TestCloudFrontStructure_flattenQueryStringCacheKeys (0.00s)
--- PASS: TestCloudFrontStructure_expandOriginGroups (0.00s)
--- PASS: TestCloudFrontStructure_flattenOrigins (0.00s)
--- PASS: TestCloudFrontStructure_flattenOriginGroups (0.00s)
--- PASS: TestCloudFrontStructure_expandOrigins (0.00s)
--- PASS: TestCloudFrontStructure_flattenHeaders (0.00s)
--- PASS: TestCloudFrontStructure_expandOrigin (0.03s)
--- PASS: TestCloudFrontStructure_expandCustomHeaders (0.00s)
--- PASS: TestCloudFrontStructure_expandOriginCustomHeader (0.00s)
--- PASS: TestCloudFrontStructure_flattenOrigin (0.00s)
--- PASS: TestCloudFrontStructure_flattenOriginCustomHeader (0.00s)
--- PASS: TestCloudFrontStructure_flattenCustomHeaders (0.00s)
--- PASS: TestCloudFrontStructure_expandCustomOriginConfig (0.00s)
--- PASS: TestCloudFrontStructure_flattenCustomOriginConfig (0.00s)
--- PASS: TestCloudFrontStructure_expandCustomOriginConfigSSL (0.00s)
--- PASS: TestCloudFrontStructure_expandCustomErrorResponse_emptyResponseCode (0.00s)
--- PASS: TestCloudFrontStructure_expandCustomErrorResponses (0.00s)
--- PASS: TestCloudFrontStructure_flattenCustomErrorResponses (0.00s)
--- PASS: TestCloudFrontStructure_expandS3OriginConfig (0.00s)
--- PASS: TestCloudFrontStructure_flattenCustomOriginConfigSSL (0.00s)
--- PASS: TestCloudFrontStructure_flattenS3OriginConfig (0.00s)
--- PASS: TestCloudFrontStructure_expandCustomErrorResponse (0.00s)
--- PASS: TestCloudFrontStructure_expandLoggingConfig (0.00s)
--- PASS: TestCloudFrontStructure_flattenAliases (0.00s)
--- PASS: TestCloudFrontStructure_expandLoggingConfig_nilValue (0.00s)
--- PASS: TestCloudFrontStructure_flattenCustomErrorResponse (0.00s)
--- PASS: TestCloudFrontStructure_expandGeoRestriction_whitelist (0.00s)
--- PASS: TestCloudFrontStructure_expandAliases (0.00s)
--- PASS: TestCloudFrontStructure_flattenGeoRestriction_whitelist (0.00s)
--- PASS: TestCloudFrontStructure_expandRestrictions (0.00s)
--- PASS: TestCloudFrontStructure_expandViewerCertificate_iam_certificate_id (0.00s)
--- PASS: TestCloudFrontStructure_expandViewerCertificate_acm_certificate_arn (0.00s)
--- PASS: TestCloudFrontStructure_expandGeoRestriction_no_items (0.00s)
--- PASS: TestCloudFrontStructure_flattenGeoRestriction_no_items (0.00s)
--- PASS: TestCloudFrontStructure_expandViewerCertificate_cloudfront_default_certificate (0.00s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (11.59s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (11.71s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_TrustedSigners (175.99s)
--- PASS: TestAccAWSCloudFrontDistribution_disappears (187.44s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_RealtimeLogConfigArn (222.92s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Headers (241.77s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (230.25s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_ForwardedValues_Headers (236.29s)
--- PASS: TestAccAWSCloudFrontDistribution_OrderedCacheBehavior_RealtimeLogConfigArn (252.45s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (249.87s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_disappears (55.94s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_basic (58.26s)
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_updates (100.08s)
--- PASS: TestAccAWSCloudFrontDistribution_DefaultCacheBehavior_ForwardedValues_Cookies_WhitelistedNames (371.88s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (384.25s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (386.58s)
--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (387.70s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (388.00s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (389.61s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (389.96s)
--- PASS: TestAccAWSCloudFrontDistribution_RetainOnDelete (390.05s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (391.51s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (392.27s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (230.13s)
--- PASS: TestAccAWSCloudFrontDistribution_Enabled (567.94s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (568.65s)
--- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (346.83s)
--- PASS: TestAccAWSCloudFrontDistribution_WaitForDeployment (386.97s)

--- FAIL: TestAccAWSCloudFrontDistribution_originPolicy (11.53s) -- unrelated to changes here; relates to #17342

@ewbankkit
r/aws_cloudfront_realtime_log_config: Additional context for creation…
246b508 
… failure.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCloudFrontRealtimeLogConfig_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudFrontRealtimeLogConfig_basic -timeout 120m
=== RUN   TestAccAWSCloudFrontRealtimeLogConfig_basic
=== PAUSE TestAccAWSCloudFrontRealtimeLogConfig_basic
=== CONT  TestAccAWSCloudFrontRealtimeLogConfig_basic
--- PASS: TestAccAWSCloudFrontRealtimeLogConfig_basic (55.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.936s
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Feb 11, 2021
@ewbankkit
Copy link
Contributor Author

@anGie44 Nits picked.

anGie44
anGie44 reviewed Feb 11, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ewbankkit ! Last 2 I promise 🤣

aws/resource_aws_cloudfront_realtime_log_config.go Outdated Show resolved Hide resolved
aws/resource_aws_cloudfront_realtime_log_config.go Outdated Show resolved Hide resolved
ewbankkit and others added 2 commits February 11, 2021 14:00
@ewbankkit @anGie44
Update aws/resource_aws_cloudfront_realtime_log_config.go
ad997d9 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@ewbankkit @anGie44
Update aws/resource_aws_cloudfront_realtime_log_config.go
4456c98 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@anGie44 anGie44 modified the milestones: v2.70.1, v3.28.0 Feb 11, 2021
@anGie44 anGie44 merged commit 8bc4d5f into hashicorp:main Feb 11, 2021
@ewbankkit ewbankkit deleted the f-aws_cloudfront_realtime_log_config-resource branch February 11, 2021 20:37
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.

CloudFront: Support real-time logs
10 participants
@ewbankkit @ken5scal @richerve @acsgh @CajuCLC @spider-network @rajholla @srgustafson8 @anGie44 @DrFaust92