Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Route 53 VPC Query Logging Configurations #15009

Closed
kylehodgetts opened this issue Sep 3, 2020 · 3 comments
Closed

Support for Route 53 VPC Query Logging Configurations #15009

kylehodgetts opened this issue Sep 3, 2020 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/ec2 Issues and PRs that pertain to the ec2 service. service/route53 Issues and PRs that pertain to the route53 service.

Comments

@kylehodgetts
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Since the 27th of August 2020, AWS now supports VPC DNS Query Logging in Route53 Resolvers.
This eliminates the need for any special setup within the VPC to handle this yourself.

It would be useful to have the Terraform resources to support this, for adding to vpc modules, for example.

New or Affected Resource(s)

  • aws_route53_vpc_query_logging_configuration

Potential Terraform Configuration

resource "aws_cloudwatch_log_group" "myloggroup" {...}
data "aws_vpc" "vpc1" {...}
...
data "aws_vpc" "vpcn" {...}

resource "aws_route53_vpc_query_logging_configuration" "example" {
    name = "example"
    destination { # only one destination block can be specified
        type = "cloud watch" # "cloud watch", "s3", "kinesis"
        name = aws_cloudwatch_log_group.myloggroup.name
    }
    vpc_ids = [
        aws_vpc.vpc1.id,
        ...
        aws_vpc.vpcn.id,
    ]

    tags = {...}
}

References

@kylehodgetts kylehodgetts added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 3, 2020
@ghost ghost added service/cloudwatchlogs service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/ec2 Issues and PRs that pertain to the ec2 service. service/route53 Issues and PRs that pertain to the route53 service. labels Sep 3, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 3, 2020
@ewbankkit
Copy link
Contributor

@kylehodgetts Thanks for raising this issue.
It has already been noticed in #14877. I'm going to close this one as a duplicate so that we can concentrate discussion in the linked issue.
Please add any additional comments there.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 3, 2020
@kylehodgetts
Copy link
Author

@ewbankkit Ah I see. Thanks for linking it.

@ghost
Copy link

ghost commented Oct 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/ec2 Issues and PRs that pertain to the ec2 service. service/route53 Issues and PRs that pertain to the route53 service.
Projects
None yet
Development

No branches or pull requests

2 participants