Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_instance,r/aws_launch_template: Handle credit_specification for new EC2 T4g instance family #15156

Closed
ewbankkit opened this issue Sep 15, 2020 · 4 comments · Fixed by #25161
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 15, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

There is a new burstable Amazon EC2 instance family, T4g.
The aws_instance.credit_specification attribute needs to be handled as for the T3 instance family.

T4g instances are designed for applications that don’t use CPU at full power most of the time, using the same credit model as T3 instances with unlimited mode enabled by default.

New or Affected Resource(s)

Resources

Data sources

Potential Terraform Configuration

resource "aws_instance" "example" {
  instance_type = "t4g.micro"
}

References

Announcement.
Blog post.

@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 15, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 15, 2020
@ewbankkit ewbankkit changed the title r/aws_instance: Handle credit_specification for new T4g instance family r/aws_instance: Handle credit_specification for new EC2 T4g instance family Sep 15, 2020
@ewbankkit ewbankkit changed the title r/aws_instance: Handle credit_specification for new EC2 T4g instance family r/aws_instance,r/aws_launch_template: Handle credit_specification for new EC2 T4g instance family Sep 15, 2020
@jackluo923
Copy link

jackluo923 commented Mar 1, 2021

Any updates on this? The pull request has been in WIP for half a year. Do you plan on continue working on it or is it abandoned? @ewbankkit

Update: For anyone who needs to modify default credit specifications for t4g or any other not-yet-supported ec2 instances in terraform is by setting the default credit specification in aws itself as a temporary workaround. See link here: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/burstable-performance-instances-how-to.html#burstable-performance-instance-set-default-credit-specification-for-account

@jetxr
Copy link

jetxr commented Jun 15, 2022

The credit_specification gets ignored for t4g instances. You have to manually change it. Any reason why this is the case?

@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants