service/workspaces: acctests/sweepers return error when resource not found

[gdavison]

Affected AccTests:

• TestAccAwsWorkspacesWorkspace_basic
• TestAccAwsWorkspacesWorkspace_tags

Affected Sweepers

• aws_workspaces_workspace
• aws_workspaces_directory

Expected Behavior

The acctests/sweepers should not return an error, since we are waiting for the absence of the resource.

Actual Behavior

The acctest/sweeper returns the error workspace "ws-g7mcyy6c6" was not terminated: couldn't find resource (21 retries).

How to Fix

When waiting for a resource to be removed, WaitForState() should have an empty Target, and the state function should return nil, "", nil

[bflad]

FYI this effects the testing as well:

=== CONT  TestAccAwsWorkspacesWorkspace_basic
TestAccAwsWorkspacesWorkspace_basic: testing_new.go:22: WARNING: destroy failed, so remote objects may still exist and be subject to billing
TestAccAwsWorkspacesWorkspace_basic: testing_new.go:22: failed to destroy: terraform failed: exit status 1
stderr:
Error: workspace "ws-g28127fnr" was not terminated: couldn't find resource (21 retries)
--- FAIL: TestAccAwsWorkspacesWorkspace_basic (1544.62s)

=== CONT  TestAccAwsWorkspacesWorkspace_tags
TestAccAwsWorkspacesWorkspace_tags: testing_new.go:22: WARNING: destroy failed, so remote objects may still exist and be subject to billing
TestAccAwsWorkspacesWorkspace_tags: testing_new.go:22: failed to destroy: terraform failed: exit status 1
stderr:
Error: workspace "ws-bzvj5njdh" was not terminated: couldn't find resource (21 retries)
--- FAIL: TestAccAwsWorkspacesWorkspace_tags (1672.55s)

[ghost]

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!