Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent destination field naming for route table #15275

Closed
gdavison opened this issue Sep 22, 2020 · 3 comments
Closed

Inconsistent destination field naming for route table #15275

gdavison opened this issue Sep 22, 2020 · 3 comments
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@gdavison
Copy link
Contributor

The AWS API field names for route table route destinations are DestinationCidrBlock, DestinationIpv6CidrBlock, and DestinationPrefixListId.

In aws_route_table and data.aws_route_table, the inline route fields are cidr_block and ipv6_cidr_block (#15273 adds DestinationPrefixListId). In aws_route and data.aws_route, the fields are named destination_cidr_block, destination_ipv6_cidr_block, and destination_prefix_list_id.

Naming should be made consistent and the old names deprecated.

Affected Resources

  • aws_route_table
  • data.aws_route_table
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 22, 2020
@ewbankkit
Copy link
Contributor

For #15273 I am going with destination_prefix_list_id.

@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Jan 18, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2023
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

2 participants