Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/rds: Prevent ordering differences with enabled_cloudwatch_logs_exports arguments #15404

Merged
merged 2 commits into from
Sep 30, 2020
Merged

service/rds: Prevent ordering differences with enabled_cloudwatch_logs_exports arguments #15404

merged 2 commits into from
Sep 30, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 30, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6799
Closes #11208

Release note for CHANGELOG:

* resource/aws_db_instance: Prevent ordering differences with `enabled_cloudwatch_logs_exports` argument
* resource/aws_rds_cluster: Prevent ordering differences with `enabled_cloudwatch_logs_exports` argument

Output from acceptance testing:

--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (552.53s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (742.59s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (805.86s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MySQL (828.42s)

--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_Postgresql (133.14s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_MySQL (243.49s)

@bflad bflad added the bug Addresses a defect in current functionality. label Sep 30, 2020
@bflad bflad requested a review from a team September 30, 2020 15:13
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 30, 2020
@bflad
service/rds: Prevent ordering differences with enabled_cloudwatch_log…
53684c4 
…s_exports arguments

Reference: #6799

Changes:

```
* resource/aws_db_instance: Prevent ordering differences with `enabled_cloudwatch_logs_exports` argument
* resource/aws_rds_cluster: Prevent ordering differences with `enabled_cloudwatch_logs_exports` argument
```

Output from acceptance testing:

```
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (552.53s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (742.59s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (805.86s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MySQL (828.42s)

--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_Postgresql (133.14s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_MySQL (243.49s)
```
@bflad bflad force-pushed the b-rds-enabled_cloudwatch_logs_exports branch from 2d8675b to 53684c4 Compare September 30, 2020 15:24
@anGie44 anGie44 self-requested a review September 30, 2020 15:49
anGie44
anGie44 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

Output of relevant acceptance tests:

--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (510.27s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (711.95s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MySQL (903.07s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (904.09s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_Postgresql (126.92s)
--- PASS: TestAccAWSRDSCluster_EnabledCloudwatchLogsExports_MySQL (208.10s)

Edit: in the documentation the list is used for this argument, we could change it to set if this change puts some confusion on a user but in general I don't see use of set in many places.

@bflad
Copy link
Contributor Author

bflad commented Sep 30, 2020

That is a good catch, will fix that on merge. 👍

@bflad bflad added this to the v3.9.0 milestone Sep 30, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Sep 30, 2020
@bflad bflad merged commit e903501 into master Sep 30, 2020
@bflad bflad deleted the b-rds-enabled_cloudwatch_logs_exports branch September 30, 2020 19:58
bflad added a commit that referenced this pull request Sep 30, 2020
@bflad
Update CHANGELOG for #15404
a46ddb7
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.9.0
2 participants
@bflad @anGie44