Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_datasync_location_s3: Add agent_arns and s3_storage_class arguments #15418

Closed
bflad opened this issue Oct 1, 2020 · 6 comments · Fixed by #18547
Closed

resource/aws_datasync_location_s3: Add agent_arns and s3_storage_class arguments #15418

bflad opened this issue Oct 1, 2020 · 6 comments · Fixed by #18547
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/datasync Issues and PRs that pertain to the datasync service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Oct 1, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As part of the initial S3 on Outposts support for the Terraform AWS Provider, enhancements to the aws_datasync_location_s3 resource are necessary.

Existing Resource

  • aws_datasync_location_s3

Potential Terraform Configuration

resource "aws_datasync_location_s3" "outposts" {
  agent_arns    = [aws_datasync_agent.example.arn]
  s3_bucket_arn = aws_s3_access_point.example.arn
  subdirectory  = "/"

  s3_config {
    bucket_access_role_arn = aws_iam_role.example.arn
  }
}

References

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/datasync Issues and PRs that pertain to the datasync service. labels Oct 1, 2020
@bflad bflad self-assigned this Oct 1, 2020
@olgakogan
Copy link

Awesome! Note that for S3 on Outposts, DataSync only supports S3 Access Points, so the bucket ARN is an Acces Point ARN

@bflad
Copy link
Contributor Author

bflad commented Oct 9, 2020

Good catch, @olgakogan! Will update the example.

@bflad bflad removed their assignment Jan 22, 2021
@cesarpball
Copy link

Do we have any update about s3_storage_class property?
Using local-exec to update the location is not an option as we can't do even in the AWS Console

@ewbankkit
Copy link
Contributor

@github-actions github-actions bot added this to the v3.40.0 milestone May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/datasync Issues and PRs that pertain to the datasync service.
Projects
None yet
4 participants