Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_ecs_cluster: Retry CreateCluster for IAM Service Linked Role eventual consistency #15457

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 2, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15452

Release note for CHANGELOG:

* resource/aws_ecs_cluster: Prevent IAM Service Linked Role error on first ECS provision

Output from acceptance testing:

--- PASS: TestAccAWSEcsCluster_disappears (22.48s)
--- PASS: TestAccAWSEcsCluster_basic (27.36s)
--- PASS: TestAccAWSEcsCluster_Tags (46.73s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (49.40s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (53.36s)
--- PASS: TestAccAWSEcsCluster_containerInsights (65.48s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (83.87s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (90.92s)

…Role eventual consistency

Reference: #15452

Output from acceptance testing:

```
--- PASS: TestAccAWSEcsCluster_disappears (22.48s)
--- PASS: TestAccAWSEcsCluster_basic (27.36s)
--- PASS: TestAccAWSEcsCluster_Tags (46.73s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (49.40s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (53.36s)
--- PASS: TestAccAWSEcsCluster_containerInsights (65.48s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (83.87s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (90.92s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Oct 2, 2020
@bflad bflad requested a review from a team October 2, 2020 16:46
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. labels Oct 2, 2020
@anGie44 anGie44 self-requested a review October 7, 2020 19:10
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

Output of acceptance tests (commercial):

--- PASS: TestAccAWSEcsCluster_disappears (20.64s)
--- PASS: TestAccAWSEcsCluster_basic (24.82s)
--- PASS: TestAccAWSEcsCluster_Tags (42.07s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (44.67s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (51.05s)
--- PASS: TestAccAWSEcsCluster_containerInsights (60.41s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (76.37s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (98.04s)

Output (gov partition):

--- PASS: TestAccAWSEcsCluster_disappears (28.48s)
--- PASS: TestAccAWSEcsCluster_basic (37.22s) 
--- FAIL: TestAccAWSEcsCluster_containerInsights (42.55s) -- tracking unrelated failure in #15549
--- PASS: TestAccAWSEcsCluster_Tags (53.51s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (57.67s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (63.90s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (71.54s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (85.65s)

@bflad bflad added this to the v3.10.0 milestone Oct 7, 2020
@bflad bflad merged commit f4a7a5f into master Oct 7, 2020
@bflad bflad deleted the b-aws_ecs_cluster-iam-retries branch October 7, 2020 20:18
bflad added a commit that referenced this pull request Oct 7, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very first creation of an ECS cluster fails
2 participants