Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_s3_bucket_ownership_controls #15482

Merged
merged 2 commits into from
Oct 8, 2020
Merged

New Resource: aws_s3_bucket_ownership_controls #15482

merged 2 commits into from
Oct 8, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15471

Release note for CHANGELOG:

* **New Resource:** `aws_s3_bucket_ownership_controls`

Output from acceptance testing:

--- PASS: TestAccAWSS3BucketOwnershipControls_disappears_Bucket (20.73s)
--- PASS: TestAccAWSS3BucketOwnershipControls_disappears (30.25s)
--- PASS: TestAccAWSS3BucketOwnershipControls_basic (31.85s)
--- PASS: TestAccAWSS3BucketOwnershipControls_Rule_ObjectOwnership (57.12s)

@bflad
New Resource: aws_s3_bucket_ownership_controls
1215f8a 
Reference: #15471

Output from acceptance testing:

```
--- PASS: TestAccAWSS3BucketOwnershipControls_disappears_Bucket (20.73s)
--- PASS: TestAccAWSS3BucketOwnershipControls_disappears (30.25s)
--- PASS: TestAccAWSS3BucketOwnershipControls_basic (31.85s)
--- PASS: TestAccAWSS3BucketOwnershipControls_Rule_ObjectOwnership (57.12s)
```
@bflad bflad added the new-resource Introduces a new resource. label Oct 5, 2020
@bflad bflad requested a review from a team October 5, 2020 12:56
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 5, 2020
@gdavison gdavison self-assigned this Oct 7, 2020
gdavison
gdavison approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM 🚀

--- PASS: TestAccAWSS3BucketOwnershipControls_disappears_Bucket (14.89s)
--- PASS: TestAccAWSS3BucketOwnershipControls_basic (19.81s)
--- PASS: TestAccAWSS3BucketOwnershipControls_disappears (19.93s)
--- PASS: TestAccAWSS3BucketOwnershipControls_Rule_ObjectOwnership (31.68s)

aws/resource_aws_s3_bucket_ownership_controls.go Outdated Show resolved Hide resolved
@bflad @gdavison
Update aws/resource_aws_s3_bucket_ownership_controls.go
20b4b41 
Co-authored-by: Graham Davison <gdavison@hashicorp.com>
@gdavison gdavison merged commit bf253d4 into master Oct 8, 2020
@gdavison gdavison deleted the f-aws_s3_bucket_ownership_controls branch October 8, 2020 18:49
gdavison added a commit that referenced this pull request Oct 8, 2020
@gdavison
Update CHANGELOG for #15482
571d897
@gdavison gdavison added this to the v3.10.0 milestone Oct 8, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.10.0
Development

Successfully merging this pull request may close these issues.

Support Amazon S3 Object Ownership
2 participants
@bflad @gdavison