Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_acm_certificate: Check for resource.TimeoutError on deletion #15522

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 6, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #12985

Release note for CHANGELOG:

* resource/aws_acm_certificate: Prevent unexpected timeout error on deletion due to API throttling

Output from acceptance testing:

--- PASS: TestAccAWSAcmCertificate_disableCTLogging (26.96s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (30.48s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (28.03s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (61.12s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (23.20s)
--- PASS: TestAccAWSAcmCertificate_privateCert (31.56s)
--- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (39.80s)
--- PASS: TestAccAWSAcmCertificate_root (29.49s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (3.09s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (25.69s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (31.05s)
--- PASS: TestAccAWSAcmCertificate_san_single (25.76s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (28.42s)
--- PASS: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (3.41s)
--- PASS: TestAccAWSAcmCertificate_wildcard (29.34s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (28.22s)
--- PASS: TestAccAWSAcmCertificate_tags (81.57s)

…tion

Reference: #12985

Output from acceptance testing:

```
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (26.96s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (30.48s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (28.03s)
--- PASS: TestAccAWSAcmCertificate_imported_DomainName (61.12s)
--- PASS: TestAccAWSAcmCertificate_imported_IpAddress (23.20s)
--- PASS: TestAccAWSAcmCertificate_privateCert (31.56s)
--- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (39.80s)
--- PASS: TestAccAWSAcmCertificate_root (29.49s)
--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (3.09s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (25.69s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (31.05s)
--- PASS: TestAccAWSAcmCertificate_san_single (25.76s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (28.42s)
--- PASS: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (3.41s)
--- PASS: TestAccAWSAcmCertificate_wildcard (29.34s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (28.22s)
--- PASS: TestAccAWSAcmCertificate_tags (81.57s)
```
@bflad bflad added bug Addresses a defect in current functionality. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Oct 6, 2020
@bflad bflad requested a review from a team October 6, 2020 17:06
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/acm Issues and PRs that pertain to the acm service. labels Oct 6, 2020
@YakDriver YakDriver self-assigned this Oct 7, 2020
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides LimitExceededException looks good:

--- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (3.58s)
--- PASS: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (3.67s)
--- FAIL: TestAccAWSAcmCertificate_PrivateKey_Tags (7.83s)
--- FAIL: TestAccAWSAcmCertificate_imported_IpAddress (7.80s)
--- FAIL: TestAccAWSAcmCertificate_imported_DomainName (8.94s)
--- PASS: TestAccAWSAcmCertificate_disableCTLogging (28.11s)
--- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (28.34s)
--- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (28.37s)
--- PASS: TestAccAWSAcmCertificate_root (28.45s)
--- PASS: TestAccAWSAcmCertificate_emailValidation (28.57s)
--- PASS: TestAccAWSAcmCertificate_san_multiple (30.79s)
--- PASS: TestAccAWSAcmCertificate_san_single (31.32s)
--- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (31.46s)
--- PASS: TestAccAWSAcmCertificate_wildcard (31.60s)
--- PASS: TestAccAWSAcmCertificate_privateCert (32.11s)
--- PASS: TestAccAWSAcmCertificate_dnsValidation (33.36s)
--- PASS: TestAccAWSAcmCertificate_tags (66.05s)

@bflad bflad added this to the v3.10.0 milestone Oct 7, 2020
@bflad bflad merged commit 929cc27 into master Oct 7, 2020
@bflad bflad deleted the b-aws_acm_certificate-TimeoutError branch October 7, 2020 19:01
bflad added a commit that referenced this pull request Oct 7, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/acm Issues and PRs that pertain to the acm service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants