Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_s3outposts_endpoint #15585

Merged
merged 2 commits into from
Oct 27, 2020
Merged

New Resource: aws_s3outposts_endpoint #15585

merged 2 commits into from
Oct 27, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 9, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Requires #15468
Reference: #15412
Closes #15417

Release note for CHANGELOG:

* **New Resource:** `aws_s3outposts_endpoint`

Output from acceptance testing:

--- PASS: TestAccAWSS3OutpostsEndpoint_basic (193.07s)
--- PASS: TestAccAWSS3OutpostsEndpoint_disappears (193.29s)

@bflad bflad added new-resource Introduces a new resource. service/s3outposts Issues and PRs that pertain to the s3outposts service. labels Oct 9, 2020
@bflad bflad requested a review from a team October 9, 2020 21:17
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 9, 2020
@bflad
New Resource: aws_s3outposts_endpoint
c8cc7d2 
Reference: #15412
Reference: #15417

Output from acceptance testing:

```
--- PASS: TestAccAWSS3OutpostsEndpoint_basic (193.07s)
--- PASS: TestAccAWSS3OutpostsEndpoint_disappears (193.29s)
```
@bflad bflad force-pushed the f-aws_s3outposts_endpoint branch from 3b6f080 to c8cc7d2 Compare October 12, 2020 17:29
anGie44
anGie44 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

aws/resource_aws_s3outposts_endpoint.go
return fmt.Errorf("error setting network_interfaces: %w", err)
}

d.Set("outpost_id", endpoint.OutpostsId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outposts vs Outpost 🤷‍♀️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Create and Delete functions refer to it in the singular and recent ELBv2 support also refers to it in the singular: https://github.com/terraform-providers/terraform-provider-aws/pull/15170/files 🙁

@bflad bflad added this to the v3.13.0 milestone Oct 27, 2020
@bflad bflad merged commit 486361f into master Oct 27, 2020
@bflad bflad deleted the f-aws_s3outposts_endpoint branch October 27, 2020 21:28
bflad added a commit that referenced this pull request Oct 27, 2020
@bflad
Update CHANGELOG for #15585
fdd08af
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3outposts Issues and PRs that pertain to the s3outposts service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.

New Resource: aws_s3outposts_endpoint
2 participants
@bflad @anGie44