Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lb_target_group: Allow invalid stickiness config, avoid breaking change #15613

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 12, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15603

Release note for CHANGELOG:

Allow invalid configurations that were allowed prior to 3.10.

The output from acceptance testing (GovCloud):

--- PASS: TestAccAWSLBTargetGroup_generatedName (40.86s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (40.99s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (41.03s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (48.48s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (49.34s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (50.62s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (59.21s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (23.52s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (32.28s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (77.30s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (82.51s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (83.38s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (84.64s)
--- PASS: TestAccAWSLBTargetGroupAttachment_lambda (44.47s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (87.52s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (38.22s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (88.25s)
--- PASS: TestAccAWSLBTargetGroup_basic (39.35s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (92.62s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (96.76s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (98.01s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (74.99s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (118.41s)
--- PASS: TestAccAWSLBTargetGroup_tags (121.59s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (40.67s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (133.30s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (59.85s)
--- PASS: TestAccAWSLBTargetGroupAttachment_Port (93.30s)
--- PASS: TestAccAWSLBTargetGroupAttachment_ipAddress (94.36s)
--- PASS: TestAccAWSLBTargetGroupAttachment_BackwardsCompatibility (93.26s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (168.99s)
--- PASS: TestAccAWSLBTargetGroupAttachment_disappears (93.33s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (97.18s)

The output from acceptance testing (commercial):

--- PASS: TestAccAWSLBTargetGroup_generatedName (36.09s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (36.13s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (37.18s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (37.36s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (41.56s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (47.30s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (60.50s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (27.15s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (64.99s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (32.51s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (32.99s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (71.33s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (71.82s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (73.20s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (74.78s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (19.19s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (81.91s)
--- PASS: TestAccAWSLBTargetGroupAttachment_lambda (36.98s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (86.84s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (93.53s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (95.29s)
--- PASS: TestAccAWSLBTargetGroup_basic (31.70s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (33.60s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (62.11s)
--- PASS: TestAccAWSLBTargetGroup_tags (99.93s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (66.00s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (126.24s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (145.36s)
--- PASS: TestAccAWSLBTargetGroupAttachment_Port (89.55s)
--- PASS: TestAccAWSLBTargetGroupAttachment_BackwardsCompatibility (89.05s)
--- PASS: TestAccAWSLBTargetGroupAttachment_disappears (98.74s)
--- PASS: TestAccAWSLBTargetGroupAttachment_ipAddress (110.10s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (219.84s)

@YakDriver YakDriver requested a review from a team October 12, 2020 22:53
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 12, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 12, 2020
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Oct 12, 2020
@YakDriver YakDriver force-pushed the b-fed-lb-sticky branch 3 times, most recently from a7f1baf to f755060 Compare October 13, 2020 16:13
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Oct 13, 2020
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments, but otherwise LGTM 🚀

--- PASS: TestLBTargetGroupCloudwatchSuffixFromARN (0.00s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (33.32s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (34.15s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (34.48s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (49.61s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (51.07s)
--- PASS: TestAccAWSLBTargetGroup_basic (61.68s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (66.13s)
--- PASS: TestAccAWSLBTargetGroupAttachment_lambda (69.68s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (90.34s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (92.43s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (91.74s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (93.66s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (94.47s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (102.49s)
--- PASS: TestAccAWSLBTargetGroupAttachment_disappears (104.87s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (109.08s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (47.71s)
--- PASS: TestAccAWSLBTargetGroupAttachment_BackwardsCompatibility (114.94s)
--- PASS: TestAccAWSLBTargetGroupAttachment_ipAddress (115.22s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (85.20s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (87.87s)
--- PASS: TestAccAWSLBTargetGroupAttachment_Port (125.06s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (39.41s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (64.09s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (39.84s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (84.09s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (134.51s)
--- PASS: TestAccAWSLBTargetGroup_tags (107.53s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (48.70s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (95.99s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (54.76s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (80.87s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (85.28s)

aws/resource_aws_lb_target_group.go Show resolved Hide resolved
aws/resource_aws_lb_target_group.go Show resolved Hide resolved
@YakDriver YakDriver merged commit 2713c91 into master Nov 10, 2020
@YakDriver YakDriver deleted the b-fed-lb-sticky branch November 10, 2020 21:09
@YakDriver YakDriver added this to the v3.15.0 milestone Nov 10, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partition/aws-us-gov Pertains to the aws-us-gov partition. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stickiness support for source_ip broke valid configurations for NLB
2 participants