-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lb_target_group: Allow invalid stickiness config, avoid breaking change #15613
Conversation
8ea3f1b
to
a3b0231
Compare
a7f1baf
to
f755060
Compare
f755060
to
c50d984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments, but otherwise LGTM 🚀
--- PASS: TestLBTargetGroupCloudwatchSuffixFromARN (0.00s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (33.32s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (34.15s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (34.48s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (49.61s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (51.07s)
--- PASS: TestAccAWSLBTargetGroup_basic (61.68s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (66.13s)
--- PASS: TestAccAWSLBTargetGroupAttachment_lambda (69.68s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (90.34s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (92.43s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (91.74s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (93.66s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (94.47s)
--- PASS: TestAccAWSLBTargetGroupAttachment_basic (102.49s)
--- PASS: TestAccAWSLBTargetGroupAttachment_disappears (104.87s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (109.08s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (47.71s)
--- PASS: TestAccAWSLBTargetGroupAttachment_BackwardsCompatibility (114.94s)
--- PASS: TestAccAWSLBTargetGroupAttachment_ipAddress (115.22s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (85.20s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (87.87s)
--- PASS: TestAccAWSLBTargetGroupAttachment_Port (125.06s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (39.41s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (64.09s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (39.84s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (84.09s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (134.51s)
--- PASS: TestAccAWSLBTargetGroup_tags (107.53s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (48.70s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (95.99s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (54.76s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (80.87s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (85.28s)
This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #15603
Release note for CHANGELOG:
The output from acceptance testing (GovCloud):
The output from acceptance testing (commercial):