e - fsx - updated max retention days from 35 to 90

[philnichol]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15636
Closes #15655

Release note for CHANGELOG:

Increased fsx_windows_file_system maximum automatic_backup_retention_days from 35 to 90.
Increased fsx_lustre_file_system maximum automatic_backup_retention_days from 35 to 90.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
$ TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays -timeout 60m
=== RUN   TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== PAUSE TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
=== CONT  TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays
--- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (3102.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3104.356s

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays -timeout 60m
=== RUN   TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
=== CONT  TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (667.77s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	669.709s

As per docs the maximum retention days should indeed be 90:
https://docs.aws.amazon.com/sdk-for-go/api/service/fsx/#CreateFileSystemWindowsConfiguration

[gdavison]

LGTM 🚀

--- FAIL: TestAccAWSFsxLustreFileSystem_ExportPath (7.54s)
--- FAIL: TestAccAWSFsxLustreFileSystem_ImportPath (8.71s)
--- FAIL: TestAccAWSFsxLustreFileSystem_ImportedFileChunkSize (8.45s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheNone (508.99s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypePersistent1 (509.70s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (527.18s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageTypeHddDriveCacheRead (550.17s)
--- PASS: TestAccAWSFsxLustreFileSystem_Tags (595.30s)
--- PASS: TestAccAWSFsxLustreFileSystem_DeploymentTypeScratch2 (610.21s)
--- PASS: TestAccAWSFsxLustreFileSystem_WeeklyMaintenanceStartTime (652.78s)
--- PASS: TestAccAWSFsxLustreFileSystem_dailyAutomaticBackupStartTime (675.67s)
--- PASS: TestAccAWSFsxLustreFileSystem_automaticBackupRetentionDays (676.26s)
--- PASS: TestAccAWSFsxLustreFileSystem_disappears (719.76s)
--- PASS: TestAccAWSFsxLustreFileSystem_KmsKeyId (1000.98s)
--- PASS: TestAccAWSFsxLustreFileSystem_autoImportPolicy (1043.18s)
--- PASS: TestAccAWSFsxLustreFileSystem_StorageCapacity (1099.66s)
--- PASS: TestAccAWSFsxLustreFileSystem_SecurityGroupIds (1204.43s)
--- PASS: TestAccAWSFsxWindowsFileSystem_disappears (3036.58s)
--- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (3112.15s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3193.43s)
--- PASS: TestAccAWSFsxWindowsFileSystem_singleAz2 (3385.56s)
--- PASS: TestAccAWSFsxWindowsFileSystem_storageTypeHdd (3484.91s)
--- PASS: TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime (3058.51s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory (2975.55s)
--- PASS: TestAccAWSFsxWindowsFileSystem_multiAz (3715.92s)
--- PASS: TestAccAWSFsxWindowsFileSystem_Tags (3076.20s)
--- PASS: TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime (3171.69s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory_Username (3835.97s)
--- PASS: TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups (4158.53s)
--- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (4147.01s)
--- PASS: TestAccAWSFsxWindowsFileSystem_KmsKeyId (4378.24s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SecurityGroupIds (4554.35s)
--- PASS: TestAccAWSFsxWindowsFileSystem_StorageCapacity (4780.45s)

Acceptance test failures are pre-existing

[ghost]

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!