aws_lambda_event_source_mapping: "Error creating Lambda event source mapping" should report the ARN of the event_source_arn in output text

[ghost]

This issue was originally opened by @jcollum as hashicorp/terraform#26654. It was migrated here as a result of the provider split. The original body of the issue is below.

---

Current Terraform Version

v0.12.29

Use-cases

When using aws_lambda_event_source_mapping the error code could help more. It's a little light on details, that's all.

Attempted Solutions

n/a/

Proposal

The output of our terraform deploy when it hits this error is:

 Error: Error creating Lambda event source mapping: InvalidParameterValueException: Error occurred while ReceiveMessage. SQS Error Code: AWS.SimpleQueueService.NonExistentQueue. SQS Error Message: The specified queue does not exist or you do not have access to it.
 {
   RespMetadata: {
     StatusCode: 400,
     RequestID: "def4a37c-105e-4d33-88a8-dddaeb009b03"
   },
   Message_: "Error occurred while ReceiveMessage. SQS Error Code: AWS.SimpleQueueService.NonExistentQueue. SQS Error Message: The specified queue does not exist or you do not have access to it.",
   Type: "User"
 }

It would be very helpful if Terraform would also output the arn that is hitting the NonExistentQueue error.

References

None recent.

[ewbankkit]

Error message uses Id before it's set:

terraform-provider-aws/aws/resource_aws_lambda_event_source_mapping.go

Lines 265 to 269 in 302ff32

	if err != nil {
	return fmt.Errorf("error creating Lambda Event Source Mapping (%s): %w", d.Id(), err)
	}
	d.SetId(aws.StringValue(eventSourceMappingConfiguration.UUID))

[ewbankkit]

Note that the event_source_arn will no longer be required when support for MQ queues and self-managed Kafka clusters is added.
I suggest logging the "target" (ARN, queue name or Kafka brokers) if create fails.

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.