-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding minimum to support host_resource_group_arn #15785
Adding minimum to support host_resource_group_arn #15785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @preflightsiren 👋 Thank you for submitting this -- it was off to a good start. I will be finishing this up to include acceptance testing so we can get this in the next release. 👍
With additional acceptance test -- Output from acceptance testing:
|
…resource_group_arn and CHANGELOG for #15785 Output from acceptance testing: ``` --- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (113.88s) --- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (112.32s) --- PASS: TestAccAWSLaunchTemplate_basic (26.20s) --- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (62.22s) --- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (80.25s) --- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_Gp3 (67.53s) --- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (30.12s) --- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (32.17s) --- PASS: TestAccAWSLaunchTemplate_cpuOptions (20.02s) --- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (23.74s) --- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (27.49s) --- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (26.61s) --- PASS: TestAccAWSLaunchTemplate_data (31.18s) --- PASS: TestAccAWSLaunchTemplate_defaultVersion (66.15s) --- PASS: TestAccAWSLaunchTemplate_description (49.72s) --- PASS: TestAccAWSLaunchTemplate_disappears (21.60s) --- PASS: TestAccAWSLaunchTemplate_EbsOptimized (90.05s) --- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (48.44s) --- PASS: TestAccAWSLaunchTemplate_enclaveOptions (70.97s) --- PASS: TestAccAWSLaunchTemplate_hibernation (70.97s) --- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (23.89s) --- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (81.70s) --- PASS: TestAccAWSLaunchTemplate_licenseSpecification (31.41s) --- PASS: TestAccAWSLaunchTemplate_metadataOptions (30.40s) --- PASS: TestAccAWSLaunchTemplate_networkInterface (71.60s) --- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (32.24s) --- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (31.31s) --- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (71.44s) --- PASS: TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination (85.38s) --- PASS: TestAccAWSLaunchTemplate_Placement_HostResourceGroupArn (33.94s) --- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (51.75s) --- PASS: TestAccAWSLaunchTemplate_tags (49.81s) --- PASS: TestAccAWSLaunchTemplate_update (80.24s) --- PASS: TestAccAWSLaunchTemplate_updateDefaultVersion (89.33s) --- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (52.34s) --- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (75.31s) --- PASS: TestAccAWSLaunchTemplateDataSource_basic (28.98s) --- PASS: TestAccAWSLaunchTemplateDataSource_enclaveOptions (29.01s) --- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (27.33s) --- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (26.50s) --- PASS: TestAccAWSLaunchTemplateDataSource_id_basic (30.08s) --- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (27.67s) --- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (61.06s) --- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (3.34s) ```
This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #15784
Release note for CHANGELOG:
Output from acceptance testing:
I haven't written any acceptance tests specifically for this change; I can't see any similar tests for other placement values. Some guidance would be useful here.
I have tested it locally against existing Launch Templates.
creating a template: