Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodePipeline webhook is not updating filter #15804

Closed
pako-grape opened this issue Oct 23, 2020 · 2 comments · Fixed by #22406
Closed

CodePipeline webhook is not updating filter #15804

pako-grape opened this issue Oct 23, 2020 · 2 comments · Fixed by #22406
Labels
bug Addresses a defect in current functionality. service/codepipeline Issues and PRs that pertain to the codepipeline service.
Milestone

Comments

@pako-grape
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.13.5

  • provider registry.terraform.io/hashicorp/aws v3.12.0

Affected Resource(s)

  • aws_codepipeline_webhook

Terraform Configuration Files

resource "aws_codepipeline_webhook" "test" {
  name            = "test"
  authentication  = "GITHUB_HMAC"
  target_action   = "Source"
  target_pipeline = "test_pipeline" // it must exist of course...

  authentication_configuration {
    secret_token = "asdf1234"
  }

  filter {
    json_path    = "$.ref"
    match_equals = "refs/heads/qwerty"
  }
}

Debug Output

Panic Output

Expected Behavior

filter properties in the resource should be updated

Actual Behavior

filter properties in the resource are not updated

Steps to Reproduce

  1. terraform apply
  2. aws codepipeline list-webhooks (all good here)
  3. change match_equals value to "refs/heads/asdf"
  4. terraform apply
  5. aws codepipeline list-webhooks (filter was not updated)

Important Factoids

References

@ghost ghost added the service/codepipeline Issues and PRs that pertain to the codepipeline service. label Oct 23, 2020
@anGie44 anGie44 added the needs-triage Waiting for first response or review from a maintainer. label Oct 27, 2020
@breathingdust breathingdust added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 16, 2021
@github-actions github-actions bot added this to the v3.71.0 milestone Jan 5, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/codepipeline Issues and PRs that pertain to the codepipeline service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants