Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_code_repository - new resource #15809

Merged
merged 24 commits into from
Oct 29, 2020
Merged

r/sagemaker_code_repository - new resource #15809

merged 24 commits into from
Oct 29, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 23, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13817

Release note for CHANGELOG:

resource_aws_sagemaker_code_repository - new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerCodeRepository_'
--- PASS: TestAccAWSSagemakerCodeRepository_disappears (26.45s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_branch (35.76s)
--- PASS: TestAccAWSSagemakerCodeRepository_basic (36.04s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_secret (84.66s)

--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo (1165.81s)

@DrFaust92 DrFaust92 requested a review from a team October 23, 2020 16:34
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 23, 2020
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Oct 23, 2020
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerCodeRepository_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerCodeRepository_ -timeout 120m
=== RUN   TestAccAWSSagemakerCodeRepository_basic
=== PAUSE TestAccAWSSagemakerCodeRepository_basic
=== RUN   TestAccAWSSagemakerCodeRepository_gitConfig_branch
=== PAUSE TestAccAWSSagemakerCodeRepository_gitConfig_branch
=== RUN   TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== PAUSE TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== RUN   TestAccAWSSagemakerCodeRepository_disappears
=== PAUSE TestAccAWSSagemakerCodeRepository_disappears
=== CONT  TestAccAWSSagemakerCodeRepository_basic
=== CONT  TestAccAWSSagemakerCodeRepository_disappears
=== CONT  TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== CONT  TestAccAWSSagemakerCodeRepository_gitConfig_branch
--- PASS: TestAccAWSSagemakerCodeRepository_disappears (17.27s)
--- PASS: TestAccAWSSagemakerCodeRepository_basic (23.32s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_branch (29.28s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_secret (46.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	46.431s

@DrFaust92
Copy link
Collaborator Author

addressed PR comments:

--- PASS: TestAccAWSSagemakerCodeRepository_disappears (26.96s)
--- PASS: TestAccAWSSagemakerCodeRepository_basic (36.97s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_branch (37.72s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_secret (85.42s)

@DrFaust92
Copy link
Collaborator Author

Added test for code repo usage in sagemaker notebook instance:

--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo (1165.81s)

ewbankkit
ewbankkit approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerCodeRepository_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerCodeRepository_ -timeout 120m
=== RUN   TestAccAWSSagemakerCodeRepository_basic
=== PAUSE TestAccAWSSagemakerCodeRepository_basic
=== RUN   TestAccAWSSagemakerCodeRepository_gitConfig_branch
=== PAUSE TestAccAWSSagemakerCodeRepository_gitConfig_branch
=== RUN   TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== PAUSE TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== RUN   TestAccAWSSagemakerCodeRepository_disappears
=== PAUSE TestAccAWSSagemakerCodeRepository_disappears
=== CONT  TestAccAWSSagemakerCodeRepository_basic
=== CONT  TestAccAWSSagemakerCodeRepository_disappears
=== CONT  TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== CONT  TestAccAWSSagemakerCodeRepository_gitConfig_branch
--- PASS: TestAccAWSSagemakerCodeRepository_disappears (17.00s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_branch (23.74s)
--- PASS: TestAccAWSSagemakerCodeRepository_basic (23.86s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_secret (47.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.118s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (336.17s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo (983.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	983.242s

@DrFaust92
Copy link
Collaborator Author

Rebased

@ewbankkit
Copy link
Contributor

Verified acceptance tests after rebase:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerCodeRepository_\|TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerCodeRepository_\|TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerCodeRepository_basic
=== PAUSE TestAccAWSSagemakerCodeRepository_basic
=== RUN   TestAccAWSSagemakerCodeRepository_gitConfig_branch
=== PAUSE TestAccAWSSagemakerCodeRepository_gitConfig_branch
=== RUN   TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== PAUSE TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== RUN   TestAccAWSSagemakerCodeRepository_disappears
=== PAUSE TestAccAWSSagemakerCodeRepository_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== CONT  TestAccAWSSagemakerCodeRepository_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== CONT  TestAccAWSSagemakerCodeRepository_disappears
=== CONT  TestAccAWSSagemakerCodeRepository_gitConfig_branch
2020/10/29 14:34:13 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/10/29 14:34:13 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/10/29 14:34:13 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
--- PASS: TestAccAWSSagemakerCodeRepository_disappears (19.23s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_branch (24.93s)
--- PASS: TestAccAWSSagemakerCodeRepository_basic (25.02s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_secret (50.26s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (393.80s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository_sagemakerRepo (1123.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1123.859s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSSagemakerCodeRepository_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerCodeRepository_ -timeout 120m
=== RUN   TestAccAWSSagemakerCodeRepository_basic
=== PAUSE TestAccAWSSagemakerCodeRepository_basic
=== RUN   TestAccAWSSagemakerCodeRepository_gitConfig_branch
=== PAUSE TestAccAWSSagemakerCodeRepository_gitConfig_branch
=== RUN   TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== PAUSE TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== RUN   TestAccAWSSagemakerCodeRepository_disappears
=== PAUSE TestAccAWSSagemakerCodeRepository_disappears
=== CONT  TestAccAWSSagemakerCodeRepository_basic
=== CONT  TestAccAWSSagemakerCodeRepository_disappears
=== CONT  TestAccAWSSagemakerCodeRepository_gitConfig_secret
=== CONT  TestAccAWSSagemakerCodeRepository_gitConfig_branch
--- PASS: TestAccAWSSagemakerCodeRepository_disappears (11.08s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_branch (15.07s)
--- PASS: TestAccAWSSagemakerCodeRepository_basic (15.27s)
--- PASS: TestAccAWSSagemakerCodeRepository_gitConfig_secret (37.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.071s

Note that Code Repositories are not currently supported in the GovCloud region.

@breathingdust breathingdust added this to the v3.13.0 milestone Oct 29, 2020
@breathingdust breathingdust merged commit 23db885 into hashicorp:master Oct 29, 2020
breathingdust added a commit that referenced this pull request Oct 29, 2020
@breathingdust
Update CHANGELOG.md for #15809
99ab914
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2020
@DrFaust92 DrFaust92 deleted the r/sagemaker_code_repository branch April 15, 2021 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.

Add support for AWS Sagemaker Code Repository resource
3 participants
@DrFaust92 @ewbankkit @breathingdust