r/sagemaker_notebook_instance - support additional repos

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_sagemaker_notebook_instance - add support for `additional_code_repositories`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1523.50s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (429.08s)

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== PAUSE TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_additional_code_repositories
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (316.79s)
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1548.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1548.169s

[breathingdust]

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== PAUSE TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_additional_code_repositories
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (418.11s)
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1451.30s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1452.923s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_additional_code_repositories\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== PAUSE TestAccAWSSagemakerNotebookInstance_additional_code_repositories
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_additional_code_repositories
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (318.54s)
--- PASS: TestAccAWSSagemakerNotebookInstance_additional_code_repositories (1377.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1379.242s

[ghost]

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!