Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the use of CloudFront Trusted Key Group as a signer #15912

Closed
briananstett opened this issue Oct 29, 2020 · 7 comments · Fixed by #18644
Closed

Support the use of CloudFront Trusted Key Group as a signer #15912

briananstett opened this issue Oct 29, 2020 · 7 comments · Fixed by #18644
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service.

Comments

@briananstett
Copy link

briananstett commented Oct 29, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS CloudFront now supports the ability to create public keys and a Trust Key Group which can be used as a signer for CloudFront signed URLs and cookies. Historically you had to use a key pair that was created by the root account user.

image

The current AWS terraform provider appears to support the creation of a CloudFront Public Key but does not appear to have support for creating the Trusted Key Group nor support for using that Trusted Key Group in the distribution.

New or Affected Resource(s)

  • A new resource for a Trusted Key Group may need to be created.
  • The existing aws_cloudfront_distribution resource may need to be updated to support the use of a Trust Key Group as a signer.

References

@briananstett briananstett added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 29, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 29, 2020
@bill-rich bill-rich added service/cloudfront Issues and PRs that pertain to the cloudfront service. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 29, 2020
@briananstett briananstett changed the title Support the use a CloudFront Trusted Key Group as a signer Support the use of CloudFront Trusted Key Group as a signer Nov 17, 2020
@schollii
Copy link

Seems this would need a new resource type aws_cloudfront_key_group that refers to a aws_cloudfront_public_key (that type of resource already exists), and a new field in aws_cloudfront_distribution to refer to the key group. Been using tf for 3 years but never created a new resource type so I have no idea how hard this is, is this something I could take on?

@shuheiktgw
Copy link
Collaborator

I've started working on this issue 👍

@shuheiktgw
Copy link
Collaborator

As a first step, I've added aws_cloudfront_key_group resource, so please upvote the PR for a faster review 🙏

Once the PR is merged, I'm going to modify aws_cloudfront_distribution to support the key group.

@shuheiktgw
Copy link
Collaborator

I've started working on adding trusted_key_groups argument since the previous PR has been merged

@shuheiktgw
Copy link
Collaborator

It's now ready for review!
#18644

@takayamaki
Copy link

I used this resource in work. Thank you!

@ghost
Copy link

ghost commented May 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants