Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Check for ClusterNotFoundException when reading ECS service #15927

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

adam-tylr
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15917

Release note for CHANGELOG:

resource/aws_ecs_service: Handle ClusterNotFoundException when reading service (#15917)

WIP

I think this will fix the issue but I'm not sure how to write acceptance tests for it. Deleting the cluster doesn't make it immediately disappear from the account. The only way I know of to simulate the error without waiting for days is to update the state after manually deleting the service to point to an invalid cluster ARN. Then when terraform tries to read the service it will get the exception. I can't figure out how to do that in the tests. I tried messing with terraform.State but it seems like that's only there for reading

@adam-tylr adam-tylr requested a review from a team October 30, 2020 02:45
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. labels Oct 30, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 30, 2020
@bill-rich bill-rich removed the needs-triage Waiting for first response or review from a maintainer. label Nov 2, 2020
@bflad bflad added the bug Addresses a defect in current functionality. label Nov 9, 2020
@bflad bflad self-assigned this Nov 9, 2020
@bflad bflad added this to the v3.15.0 milestone Nov 9, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adam-tylr 👋 Thank you for submitting this fix. Given the API Reference and behavior you documented very well (thank you!), this fix seems valid and likely would not be pragmatic to try and replicate in an acceptance test. Given the fix type and good looking implementation, I'm going to merge this as-is. Thanks! 🚀

@bflad bflad merged commit 17eb384 into hashicorp:master Nov 9, 2020
bflad added a commit that referenced this pull request Nov 9, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS plan fails if cluster has been deleted outside Terraform
3 participants