Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeartifact resources tagging support #16006

Merged
merged 5 commits into from
Nov 4, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15958

Release note for CHANGELOG:

resource_aws_codeartifact_domain - add `tags` argument.
resource_aws_codeartifact_repository - add `tags` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSCodeArtifactDomain_disappears (46.43s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (56.14s)
--- PASS: TestAccAWSCodeArtifactDomain_tags (142.23s)

--- PASS: TestAccAWSCodeArtifactRepository_disappears (55.96s)
--- PASS: TestAccAWSCodeArtifactRepository_basic (62.72s)
--- PASS: TestAccAWSCodeArtifactRepository_owner (65.24s)
--- PASS: TestAccAWSCodeArtifactRepository_description (111.50s)
--- PASS: TestAccAWSCodeArtifactRepository_tags (153.52s)
--- PASS: TestAccAWSCodeArtifactRepository_externalConnection (158.15s)
--- PASS: TestAccAWSCodeArtifactRepository_upstreams (178.47s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner November 3, 2020 19:24
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 3, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 3, 2020
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_basic\|TestAccAWSCodeArtifactDomain_tags\|TestAccAWSCodeArtifactRepository_basic\|TestAccAWSCodeArtifactRepository_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_basic\|TestAccAWSCodeArtifactDomain_tags\|TestAccAWSCodeArtifactRepository_basic\|TestAccAWSCodeArtifactRepository_tags -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_tags
=== PAUSE TestAccAWSCodeArtifactDomain_tags
=== RUN   TestAccAWSCodeArtifactRepository_basic
=== PAUSE TestAccAWSCodeArtifactRepository_basic
=== RUN   TestAccAWSCodeArtifactRepository_tags
=== PAUSE TestAccAWSCodeArtifactRepository_tags
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactRepository_tags
=== CONT  TestAccAWSCodeArtifactRepository_basic
=== CONT  TestAccAWSCodeArtifactDomain_tags
--- PASS: TestAccAWSCodeArtifactDomain_basic (29.93s)
--- PASS: TestAccAWSCodeArtifactRepository_basic (32.68s)
--- PASS: TestAccAWSCodeArtifactDomain_tags (63.67s)
--- PASS: TestAccAWSCodeArtifactRepository_tags (70.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	70.552s

Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_basic\|TestAccAWSCodeArtifactDomain_tags\|TestAccAWSCodeArtifactRepository_basic\|TestAccAWSCodeArtifactRepository_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_basic\|TestAccAWSCodeArtifactDomain_tags\|TestAccAWSCodeArtifactRepository_basic\|TestAccAWSCodeArtifactRepository_tags -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_tags
=== PAUSE TestAccAWSCodeArtifactDomain_tags
=== RUN   TestAccAWSCodeArtifactRepository_basic
=== PAUSE TestAccAWSCodeArtifactRepository_basic
=== RUN   TestAccAWSCodeArtifactRepository_tags
=== PAUSE TestAccAWSCodeArtifactRepository_tags
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactRepository_tags
=== CONT  TestAccAWSCodeArtifactRepository_basic
=== CONT  TestAccAWSCodeArtifactDomain_tags
2020/11/04 13:52:28 [DEBUG] Waiting for state to become: [success]
--- PASS: TestAccAWSCodeArtifactDomain_basic (20.36s)
--- PASS: TestAccAWSCodeArtifactRepository_basic (22.66s)
--- PASS: TestAccAWSCodeArtifactDomain_tags (53.24s)
--- PASS: TestAccAWSCodeArtifactRepository_tags (54.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	56.089s

@breathingdust breathingdust added this to the v3.14.0 milestone Nov 4, 2020
@breathingdust breathingdust merged commit 485f878 into hashicorp:master Nov 4, 2020
breathingdust added a commit that referenced this pull request Nov 4, 2020
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
@DrFaust92 DrFaust92 deleted the r/codeartifact_tags branch April 15, 2021 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS CodeArtifact resource tagging
3 participants