-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Backup Region Settings #16114
Support Backup Region Settings #16114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupRegionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupRegionSettings_ -timeout 120m
=== RUN TestAccAwsBackupRegionSettings_basic
=== PAUSE TestAccAwsBackupRegionSettings_basic
=== CONT TestAccAwsBackupRegionSettings_basic
--- PASS: TestAccAwsBackupRegionSettings_basic (29.30s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 29.352s
) | ||
|
||
func TestAccAwsBackupRegionSettings_basic(t *testing.T) { | ||
var settings backup.DescribeRegionSettingsOutput |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing in GovCloud as FSx is not available there, can we use describeRegionSettings to populate the list to check? cc: @YakDriver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The api allows for partial update (but describe actually return all services) so I can add computed to the map to reduce service keys in tests to something simple like RDS. I just wanted it to prevent any state drift issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See below
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
LGTM 🚀 Thanks @DrFaust92 Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupRegionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupRegionSettings_ -timeout 120m
=== RUN TestAccAwsBackupRegionSettings_basic
=== PAUSE TestAccAwsBackupRegionSettings_basic
=== CONT TestAccAwsBackupRegionSettings_basic
--- PASS: TestAccAwsBackupRegionSettings_basic (31.83s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 33.801s Verified Acceptance Tests in GovCloud (us-gov-west-1) make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupRegionSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupRegionSettings_ -timeout 120m
=== RUN TestAccAwsBackupRegionSettings_basic
=== PAUSE TestAccAwsBackupRegionSettings_basic
=== CONT TestAccAwsBackupRegionSettings_basic
provider_test.go:626: skipping tests; partition aws-us-gov does not support fsx service
--- SKIP: TestAccAwsBackupRegionSettings_basic (0.77s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 2.942s |
This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #13449
Release note for CHANGELOG:
Output from acceptance testing: