r/aws_globalaccelerator_endpoint_group: Support port overrides #16121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, plus validations.
…ce tests. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_basic -timeout 120m === RUN TestAccAwsGlobalAcceleratorEndpointGroup_basic === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic === CONT TestAccAwsGlobalAcceleratorEndpointGroup_basic --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (208.29s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 208.352s
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAwsGlobalAcceleratorEndpointGroup_ -timeout 120m === RUN TestAccAwsGlobalAcceleratorEndpointGroup_basic === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic === RUN TestAccAwsGlobalAcceleratorEndpointGroup_disappears === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears === RUN TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP === RUN TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint === RUN TestAccAwsGlobalAcceleratorEndpointGroup_update === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_update === RUN TestAccAwsGlobalAcceleratorEndpointGroup_tcp === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_tcp === CONT TestAccAwsGlobalAcceleratorEndpointGroup_basic === CONT TestAccAwsGlobalAcceleratorEndpointGroup_update --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (220.05s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_tcp === CONT TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_update (270.33s) --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_tcp (240.05s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (920.21s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_disappears --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (1120.46s) --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (435.74s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1816.104s
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAwsGlobalAcceleratorEndpointGroup_ -timeout 120m === RUN TestAccAwsGlobalAcceleratorEndpointGroup_basic === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic === RUN TestAccAwsGlobalAcceleratorEndpointGroup_disappears === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears === RUN TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP === RUN TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint === RUN TestAccAwsGlobalAcceleratorEndpointGroup_update === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_update === RUN TestAccAwsGlobalAcceleratorEndpointGroup_tcp === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_tcp === CONT TestAccAwsGlobalAcceleratorEndpointGroup_basic === CONT TestAccAwsGlobalAcceleratorEndpointGroup_update --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (208.39s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_tcp --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_update (249.83s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_tcp (239.95s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (698.28s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_disappears --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (593.94s) --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (217.15s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1165.315s
…torEndpointGroup_MultiRegion'. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion -timeout 120m === RUN TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion === CONT TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion (211.73s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 211.776s
…d flatten. Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_' ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAwsGlobalAcceleratorEndpointGroup_ -timeout 120m === RUN TestAccAwsGlobalAcceleratorEndpointGroup_basic === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic === RUN TestAccAwsGlobalAcceleratorEndpointGroup_disappears === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears === RUN TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP === RUN TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint === RUN TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion === RUN TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol === RUN TestAccAwsGlobalAcceleratorEndpointGroup_Update === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_Update === CONT TestAccAwsGlobalAcceleratorEndpointGroup_basic === CONT TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (250.76s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_Update --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion (264.24s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol (219.10s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_Update (258.61s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (645.67s) === CONT TestAccAwsGlobalAcceleratorEndpointGroup_disappears --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (708.54s) --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (215.56s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 1370.737s
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides -timeout 120m === RUN TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides === PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides === CONT TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides --- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides (279.43s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 279.479s
ghost
added
size/XL
DrFaust92
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
LGTM
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (229.93s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides (283.50s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol (280.32s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion (269.37s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (647.61s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (251.07s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (935.86s)
|
LGTM 🚀 Thanks @ewbankkit for the contribution! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsGlobalAcceleratorEndpointGroup_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAwsGlobalAcceleratorEndpointGroup_ -timeout 120m
=== RUN TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== RUN TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_disappears
=== RUN TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
=== RUN TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
=== RUN TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
=== RUN TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
=== RUN TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
=== RUN TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== PAUSE TestAccAwsGlobalAcceleratorEndpointGroup_Update
=== CONT TestAccAwsGlobalAcceleratorEndpointGroup_basic
=== CONT TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_basic (207.99s)
=== CONT TestAccAwsGlobalAcceleratorEndpointGroup_Update
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_PortOverrides (265.52s)
=== CONT TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_Update (306.03s)
=== CONT TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_TCPHealthCheckProtocol (282.39s)
=== CONT TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_MultiRegion (232.22s)
=== CONT TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_InstanceEndpoint (676.65s)
=== CONT TestAccAwsGlobalAcceleratorEndpointGroup_disappears
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_disappears (359.03s)
--- PASS: TestAccAwsGlobalAcceleratorEndpointGroup_ALBEndpoint_ClientIP (851.48s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 1633.172s |
breathingdust
added a commit
that referenced
this pull request
Nov 18, 2020
ewbankkit
deleted the
f-aws_globalaccelerator_endpoint_group-port_override
branch
|
This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes: #15787.
Release note for CHANGELOG:
Output from acceptance testing: