Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added disable_execute_api_endpoint argument #16198

Merged
merged 3 commits into from
Jan 13, 2021
Merged

added disable_execute_api_endpoint argument #16198

merged 3 commits into from
Jan 13, 2021

Conversation

philnichol
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15959

Release note for CHANGELOG:

resource/aws_api_gateway_rest_api - added disable_execute_api_endpoint optional argument

Output from acceptance testing:

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 10 -run=TestAccAWSAPIGatewayRestApi_ -timeout 60m
=== RUN   TestAccAWSAPIGatewayRestApi_basic
=== PAUSE TestAccAWSAPIGatewayRestApi_basic
=== RUN   TestAccAWSAPIGatewayRestApi_tags
=== PAUSE TestAccAWSAPIGatewayRestApi_tags
=== RUN   TestAccAWSAPIGatewayRestApi_disappears
=== PAUSE TestAccAWSAPIGatewayRestApi_disappears
=== RUN   TestAccAWSAPIGatewayRestApi_EndpointConfiguration
=== PAUSE TestAccAWSAPIGatewayRestApi_EndpointConfiguration
=== RUN   TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private
=== PAUSE TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private
=== RUN   TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint
=== PAUSE TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint
=== RUN   TestAccAWSAPIGatewayRestApi_api_key_source
=== PAUSE TestAccAWSAPIGatewayRestApi_api_key_source
=== RUN   TestAccAWSAPIGatewayRestApi_disable_execute_api_endpoint
=== PAUSE TestAccAWSAPIGatewayRestApi_disable_execute_api_endpoint
=== RUN   TestAccAWSAPIGatewayRestApi_policy
=== PAUSE TestAccAWSAPIGatewayRestApi_policy
=== RUN   TestAccAWSAPIGatewayRestApi_openapi
=== PAUSE TestAccAWSAPIGatewayRestApi_openapi
=== CONT  TestAccAWSAPIGatewayRestApi_basic
=== CONT  TestAccAWSAPIGatewayRestApi_api_key_source
=== CONT  TestAccAWSAPIGatewayRestApi_openapi
=== CONT  TestAccAWSAPIGatewayRestApi_disable_execute_api_endpoint
=== CONT  TestAccAWSAPIGatewayRestApi_EndpointConfiguration
=== CONT  TestAccAWSAPIGatewayRestApi_policy
=== CONT  TestAccAWSAPIGatewayRestApi_tags
=== CONT  TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint
=== CONT  TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private
=== CONT  TestAccAWSAPIGatewayRestApi_disappears
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (15.77s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (21.86s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (52.00s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (81.77s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (82.39s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (162.10s)
--- PASS: TestAccAWSAPIGatewayRestApi_disable_execute_api_endpoint (272.33s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (317.77s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (358.19s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (392.69s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       392.734s

@philnichol philnichol requested a review from a team as a code owner November 14, 2020 17:32
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 14, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 14, 2020
@lordz-md
Copy link

lordz-md commented Dec 2, 2020

Any chance to get this soon?

@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jan 13, 2021
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2021
@bflad bflad self-assigned this Jan 13, 2021
@bflad bflad added this to the v3.24.0 milestone Jan 13, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you, @philnichol 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (49.76s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (733.13s)
--- PASS: TestAccAWSAPIGatewayRestApi_disable_execute_api_endpoint (29.79s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (30.64s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (237.77s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (9.10s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_VPCEndpoint (222.18s)
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (17.50s)
--- PASS: TestAccAWSAPIGatewayRestApi_Parameters (38.95s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (437.20s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (20.53s)

@bflad bflad merged commit 801cd36 into hashicorp:master Jan 13, 2021
bflad added a commit that referenced this pull request Jan 13, 2021
@philnichol philnichol deleted the e-adding-disable-execution-api-endpoint branch January 13, 2021 06:18
@ghost
Copy link

ghost commented Jan 15, 2021

This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_api_gateway_rest_api: Disable the default REST API endpoint
3 participants