Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add launch_template to aws_autoscaling_group data source #16289

Closed
visit1985 opened this issue Nov 18, 2020 · 2 comments · Fixed by #16297
Closed

Add launch_template to aws_autoscaling_group data source #16289

visit1985 opened this issue Nov 18, 2020 · 2 comments · Fixed by #16297
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Milestone

Comments

@visit1985
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

DescribeAutoScalingGroups can return a LaunchTemplateSpecification, which is currently not exposed in the aws_autoscaling_group data source. I would like to use this values to identify the aws_launch_template which is auto-generated when a aws_eks_node_group is created.

New or Affected Resource(s)

  • data source aws_autoscaling_group

Potential Terraform Configuration

resource "aws_eks_node_group" "ng" {
  count = var.availability_zone_count
  // ...
}

data "aws_autoscaling_group" "asg" {
  count = var.availability_zone_count
  name = aws_eks_node_group.ng[count.index].resources.0.autoscaling_groups.0.name
}

data "aws_launch_template" "lt" {
  count = var.availability_zone_count
  name = data.aws_autoscaling_group.asg[count.index].launch_template.name
}

References

https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_DescribeAutoScalingGroups.html
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_AutoScalingGroup.html
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_LaunchTemplateSpecification.html

@visit1985 visit1985 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 18, 2020
@ghost ghost added service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/eks Issues and PRs that pertain to the eks service. labels Nov 18, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 18, 2020
@gdavison gdavison removed needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. service/eks Issues and PRs that pertain to the eks service. labels Nov 18, 2020
@gdavison gdavison self-assigned this Nov 19, 2020
@github-actions github-actions bot added this to the v3.22.0 milestone Dec 14, 2020
@ghost
Copy link

ghost commented Dec 18, 2020

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants