Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_cloudwatch_event_permission: Support DescribeEventBus API returning account ID or root account ARN #16319

Merged

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 19, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16318

Release note for CHANGELOG:

* resource/aws_cloudwatch_event_permission: Prevent `arn: invalid prefix` error during read due to API changes

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSCloudWatchEventPermission_Action (13.37s)
--- PASS: TestAccAWSCloudWatchEventPermission_EventBusName (14.15s)
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (19.11s)
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (20.19s)
--- PASS: TestAccAWSCloudWatchEventPermission_basic (27.21s)
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (128.53s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSCloudWatchEventPermission_EventBusName (18.98s)
--- PASS: TestAccAWSCloudWatchEventPermission_Action (19.05s)
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (26.89s)
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (27.32s)
--- PASS: TestAccAWSCloudWatchEventPermission_basic (37.01s)
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (131.57s)

… API returning account ID or root account ARN

Reference: #16318

Changes:

```
* resource/aws_cloudwatch_event_permission: Prevent `arn: invalid prefix` error during read due to API changes
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSCloudWatchEventPermission_Action (13.37s)
--- PASS: TestAccAWSCloudWatchEventPermission_EventBusName (14.15s)
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (19.11s)
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (20.19s)
--- PASS: TestAccAWSCloudWatchEventPermission_basic (27.21s)
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (128.53s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSCloudWatchEventPermission_EventBusName (18.98s)
--- PASS: TestAccAWSCloudWatchEventPermission_Action (19.05s)
--- PASS: TestAccAWSCloudWatchEventPermission_Multiple (26.89s)
--- PASS: TestAccAWSCloudWatchEventPermission_Condition (27.32s)
--- PASS: TestAccAWSCloudWatchEventPermission_basic (37.01s)
--- PASS: TestAccAWSCloudWatchEventPermission_Disappears (131.57s)
```
@bflad bflad added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. upstream Addresses functionality related to the cloud provider. labels Nov 19, 2020
@bflad bflad requested a review from a team as a code owner November 19, 2020 16:42
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/cloudwatchevents labels Nov 19, 2020
@bflad bflad changed the title resource/aws_cloudwatch_event_permission: Support DescribeEventBridge API returning account ID or root account ARN resource/aws_cloudwatch_event_permission: Support DescribeEventBus API returning account ID or root account ARN Nov 19, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix given the API changes, LGTM 🚀

@bflad bflad added this to the v3.18.0 milestone Nov 24, 2020
@bflad bflad merged commit 1ade3b4 into master Nov 24, 2020
@bflad bflad deleted the b-aws_cloudwatch_event_permission-principal-regression branch November 24, 2020 19:48
bflad added a commit that referenced this pull request Nov 24, 2020
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. size/XS Managed by automation to categorize the size of a PR. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_cloudwatch_event_permission: arn: invalid prefix Error
2 participants