Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_kinesisanalyticsv2_application: Support Apache Flink v1.11 #16389

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16364.

Release note for CHANGELOG:

resource/aws_kinesisanalyticsv2_application: `runtime_environment` now supports `FLINK-1_11`

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
=== CONT  TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
--- PASS: TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication (52.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.040s

@ewbankkit ewbankkit requested a review from a team as a code owner November 23, 2020 21:24
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 23, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 23, 2020
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication (137.28s)

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @ewbankkit

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
=== CONT  TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
--- PASS: TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication (64.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	66.307s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication -timeout 120m
=== RUN   TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
=== PAUSE TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
=== CONT  TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication
--- PASS: TestAccAWSKinesisAnalyticsV2Application_basicFlinkApplication (37.35s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	39.274s

@breathingdust breathingdust added this to the v3.18.0 milestone Nov 24, 2020
@breathingdust breathingdust merged commit 4c3d479 into hashicorp:master Nov 24, 2020
breathingdust added a commit that referenced this pull request Nov 24, 2020
@ewbankkit ewbankkit deleted the f-aws_kinesisanalyticsv2_application-FLINK-1_11 branch November 24, 2020 21:21
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 3.18.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kinesisanalyticsv2 Issues and PRs that pertain to the kinesisanalyticsv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon Kinesis Data Analytics now supports Apache Flink v1.11
3 participants