Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/lb_listner_certificate - import support #16474

Merged
merged 11 commits into from
Feb 11, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13610

Release note for CHANGELOG:

resource_aws_lb_listner_certificate - import support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsLbListenerCertificate_'
--- PASS: TestAccAwsLbListenerCertificate_basic (266.40s)
--- PASS: TestAccAwsLbListenerCertificate_multiple (450.33s)
--- PASS: TestAccAwsLbListenerCertificate_disappears (265.82s)

@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 27, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 27, 2020
@DrFaust92 DrFaust92 marked this pull request as ready for review November 27, 2020 23:01
@DrFaust92 DrFaust92 requested a review from a team as a code owner November 27, 2020 23:01
Base automatically changed from master to main January 23, 2021 00:59
@bflad bflad self-assigned this Feb 11, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just this and changelog 👍

aws/resource_aws_lb_listener_certificate.go Outdated Show resolved Hide resolved
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Feb 11, 2021
@bflad
Copy link
Contributor

bflad commented Feb 11, 2021

Oh yes, we need to add ImportState testing as well. 👍

@DrFaust92
Copy link
Collaborator Author

Added Import tests + changelog

.changelog/16474.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAwsLbListenerCertificate_disappears (170.83s)
--- PASS: TestAccAwsLbListenerCertificate_basic (176.25s)
--- PASS: TestAccAwsLbListenerCertificate_multiple (234.15s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAwsLbListenerCertificate_disappears (155.87s)
--- PASS: TestAccAwsLbListenerCertificate_basic (159.04s)
--- PASS: TestAccAwsLbListenerCertificate_multiple (251.86s)

@bflad bflad merged commit 8cb9455 into hashicorp:main Feb 11, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@greedy52
Copy link

ListenerCertificateParseID is a breaking change in 3.28.0 when the certificate name (ex: iam cert) has _ in it, as Split will return more than 2 tokens.

@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
@DrFaust92 DrFaust92 deleted the r/lb_cert_import branch April 15, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource aws_lb_listener_certificate doesn't support import
4 participants