r/backup_global_settings - add new resource #16475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/L
ewbankkit
reviewed
Nov 29, 2020
ewbankkit
reviewed
Nov 29, 2020
ewbankkit
approved these changes
Nov 29, 2020
There was a problem hiding this comment.
LGTM.
$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (31.11s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 31.167s
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
|
Curious if this one is going to be merged soon? |
|
@DrFaust92 Is this ready for re-review? |
|
@ewbankkit Yes! thank you 👍 |
ewbankkit
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
LGTM.
$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (29.95s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 29.997s
|
LGTM 🚀 Thanks @DrFaust92! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (30.56s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 32.249sVerified Acceptance Tests in GovCloud (us-gov-west-1) make testacc TEST=./aws TESTARGS='-run=TestAccAwsBackupGlobalSettings_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupGlobalSettings_ -timeout 120m
=== RUN TestAccAwsBackupGlobalSettings_basic
=== PAUSE TestAccAwsBackupGlobalSettings_basic
=== CONT TestAccAwsBackupGlobalSettings_basic
--- PASS: TestAccAwsBackupGlobalSettings_basic (20.76s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 22.499s |
|
This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #16343
Release note for CHANGELOG:
Output from acceptance testing: