feat: add aws_dx_hosted_connection and aws_dx_connection_confirmation resource

[kmcclive]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9366.
Closes #20950.

added aws_dx_hosted_connection resource
added aws_dx_connection_confirmation resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDxConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDxConnection_ -timeout 120m
=== RUN   TestAccAWSDxConnection_basic
=== PAUSE TestAccAWSDxConnection_basic
=== RUN   TestAccAWSDxConnection_tags
=== PAUSE TestAccAWSDxConnection_tags
=== CONT  TestAccAWSDxConnection_basic
=== CONT  TestAccAWSDxConnection_tags
--- PASS: TestAccAWSDxConnection_basic (35.60s)
--- PASS: TestAccAWSDxConnection_tags (49.83s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       50.017s
$ make testacc TESTARGS='-run=TestAccAWSDxHostedConnection'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDxHostedConnection -timeout 120m
=== RUN   TestAccAWSDxHostedConnection_basic
    provider_test.go:55: TEST_AWS_DX_CONNECTION_ID and TEST_AWS_DX_OWNER_ACCOUNT_ID must be set for tests involving hosted connections
--- SKIP: TestAccAWSDxHostedConnection_basic (0.00s)
=== RUN   TestAccAWSDxHostedConnection_tags
    provider_test.go:55: TEST_AWS_DX_CONNECTION_ID and TEST_AWS_DX_OWNER_ACCOUNT_ID must be set for tests involving hosted connections
--- SKIP: TestAccAWSDxHostedConnection_tags (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       0.083s
$ export TEST_AWS_DX_CONNECTION_ID=<Interconnect or LAG ID> && export TEST_AWS_DX_OWNER_ACCOUNT_ID=<Owner Account ID>
$ make testacc TESTARGS='-run=TestAccAWSDxHostedConnection'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDxHostedConnection -timeout 120m
=== RUN   TestAccAWSDxHostedConnection_basic
=== PAUSE TestAccAWSDxHostedConnection_basic
=== RUN   TestAccAWSDxHostedConnection_tags
=== PAUSE TestAccAWSDxHostedConnection_tags
=== CONT  TestAccAWSDxHostedConnection_basic
=== CONT  TestAccAWSDxHostedConnection_tags
--- PASS: TestAccAWSDxHostedConnection_tags (29.98s)
--- PASS: TestAccAWSDxHostedConnection_basic (30.26s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       30.382s
$ make testacc TESTARGS='-run=TestAccAWSDxConnectionConfirmation'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDxConnectionConfirmation -timeout 120m
=== RUN   TestAccAWSDxConnectionConfirmation_basic
=== PAUSE TestAccAWSDxConnectionConfirmation_basic
=== CONT  TestAccAWSDxConnectionConfirmation_basic
--- PASS: TestAccAWSDxConnectionConfirmation_basic (654.54s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       654.768s

[github-actions]

Welcome @kmcclive 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[kmcclive]

This may close #9366, but was given the name "connection_confirmation" instead of "connection_accepter" to be consistent with the SDK and API.

[ewbankkit]

@kmcclive Thanks for the contribution 🎉 👏.
Are you able to re-verify the acceptance tests for these 2 new resources? (cc @kevinkirkup)
I rebased and made changes to incorporate intervening work.

[ewbankkit]

% make testacc TESTARGS='-run=TestAccAwsDxLag_\|TestAccAWSDxConnectionAssociation_\|TestAccAWSDxConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDxLag_\|TestAccAWSDxConnectionAssociation_\|TestAccAWSDxConnection_ -timeout 180m
=== RUN   TestAccAWSDxConnectionAssociation_basic
=== PAUSE TestAccAWSDxConnectionAssociation_basic
=== RUN   TestAccAWSDxConnectionAssociation_LAGOnConnection
=== PAUSE TestAccAWSDxConnectionAssociation_LAGOnConnection
=== RUN   TestAccAWSDxConnectionAssociation_Multiple
=== PAUSE TestAccAWSDxConnectionAssociation_Multiple
=== RUN   TestAccAwsDxLag_basic
=== PAUSE TestAccAwsDxLag_basic
=== RUN   TestAccAwsDxLag_disappears
=== PAUSE TestAccAwsDxLag_disappears
=== RUN   TestAccAwsDxLag_ConnectionID
=== PAUSE TestAccAwsDxLag_ConnectionID
=== RUN   TestAccAwsDxLag_ProviderName
=== PAUSE TestAccAwsDxLag_ProviderName
=== RUN   TestAccAwsDxLag_Tags
=== PAUSE TestAccAwsDxLag_Tags
=== CONT  TestAccAWSDxConnectionAssociation_basic
=== CONT  TestAccAwsDxLag_ConnectionID
=== CONT  TestAccAwsDxLag_basic
=== CONT  TestAccAWSDxConnectionAssociation_LAGOnConnection
=== CONT  TestAccAwsDxLag_Tags
=== CONT  TestAccAwsDxLag_disappears
=== CONT  TestAccAWSDxConnectionAssociation_Multiple
=== CONT  TestAccAwsDxLag_ProviderName
--- PASS: TestAccAWSDxConnectionAssociation_basic (24.32s)
--- PASS: TestAccAwsDxLag_disappears (25.33s)
--- PASS: TestAccAWSDxConnectionAssociation_Multiple (27.86s)
--- PASS: TestAccAWSDxConnectionAssociation_LAGOnConnection (29.90s)
--- PASS: TestAccAwsDxLag_ConnectionID (32.05s)
--- PASS: TestAccAwsDxLag_ProviderName (33.35s)
--- PASS: TestAccAwsDxLag_basic (42.20s)
--- PASS: TestAccAwsDxLag_Tags (57.15s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.307s

[github-actions]

This functionality has been released in v3.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.