Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a custom key store Id as a KMS origin during create key #16491

Closed
ambrosy-eric opened this issue Nov 30, 2020 · 4 comments · Fixed by #24787
Closed

Accept a custom key store Id as a KMS origin during create key #16491

ambrosy-eric opened this issue Nov 30, 2020 · 4 comments · Fixed by #24787
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/kms Issues and PRs that pertain to the kms service.
Milestone

Comments

@ambrosy-eric
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently aws_kms_key only allows for creating a KMS key with a KMS origin. I would like to use a custom key store to create my keys.

KMS allows you to set a custom key store (often a cloudHSM cluster), and then use this key store to generate KMS keys without having to import key material for them directly.

As a developer I would like to be able to define in terraform an origin of my custom key store through its id.

New or Affected Resource(s)

  • aws_kms_key

New

  • data-source aws_kms_custom_store

Potential Terraform Configuration

data "aws_kms_custom_key_store" "key_store" {
  key_store_id = "my-key-store-name"
}

resource "aws_kms_key" "key" {
  description              = "My key for encrypting"
  custom_key_store   = data.aws_kms_custom_key_store.key_store.id
}

References

@ambrosy-eric ambrosy-eric added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 30, 2020
@ghost ghost added the service/kms Issues and PRs that pertain to the kms service. label Nov 30, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 30, 2020
@DrFaust92 DrFaust92 added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 30, 2020
@alexis-renard
Copy link

Hello, we are still heavily waiting for that new feature to come out. Is there any progress on it, any visibility by chance ? We had to deploy a custom API to deal with our Cloud HSM keys efficiently and securly, and would really like to use terraform to handle our HSM Keys in our workflows (therefore decomissioning our use case specific API).
Thanks !

@bbratchiv
Copy link

Hi @justinretzolk, when do you plan to release this feature? I see PR is pending above

@github-actions
Copy link

This functionality has been released in v4.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. service/kms Issues and PRs that pertain to the kms service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants