Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated network association timeout from 10 min to 30 min #16522

Conversation

connor-tyndall
Copy link
Contributor

Updated ClientVpnNetworkAssociationAssociatedTimeout and ClientVpnNetworkAssociationDisassociatedTimeout from 10 min to 30 min.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #15680

Release note for CHANGELOG:

resource/aws_ec2_client_vpn_network_association: Update timeout from 10min to 30min

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2ClientVpnNetworkAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2ClientVpnNetworkAssociation_ -timeout 120m
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.062s [no tests to run]

@connor-tyndall connor-tyndall requested a review from a team as a code owner December 2, 2020 01:40
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Dec 2, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 2, 2020
@anGie44 anGie44 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 3, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @connor-tyndall , looks great 👍

@anGie44 anGie44 added this to the v3.20.0 milestone Dec 3, 2020
@anGie44 anGie44 merged commit 190dcab into hashicorp:master Dec 3, 2020
anGie44 added a commit that referenced this pull request Dec 3, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Client VPN resources: Always time out before resource is ready
2 participants