Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/eks_node_group: remove drift detection from capacity_type argument #16552

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Dec 2, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16547

Release note for CHANGELOG:

r/eks_node_group: remove drift detection from capacity_type argument

Output from acceptance testing:

--- PASS: TestAccAWSEksNodeGroup_AmiType (1712.65s)
--- PASS: TestAccAWSEksNodeGroup_CapacityType_Spot (1419.62s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1335.99s)
--- PASS: TestAccAWSEksNodeGroup_ForceUpdateVersion (5131.91s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Multiple (1500.45s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Single (1340.39s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1396.56s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Id (1715.12s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Name (1700.75s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2425.36s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (4093.10s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1467.07s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1454.95s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1436.91s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1413.84s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1423.62s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1404.38s)
--- PASS: TestAccAWSEksNodeGroup_Version (5057.41s)
--- PASS: TestAccAWSEksNodeGroup_basic (1350.04s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1335.66s)

@anGie44 anGie44 requested a review from a team as a code owner December 2, 2020 20:03
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/eks Issues and PRs that pertain to the eks service. labels Dec 2, 2020
@anGie44 anGie44 requested a review from bflad December 2, 2020 20:07
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 (For others benefit: we confirmed with the service team that existing Node Groups would not return this information)

@anGie44 anGie44 added this to the v3.20.0 milestone Dec 2, 2020
@anGie44 anGie44 merged commit 53d8277 into master Dec 2, 2020
@anGie44 anGie44 deleted the f-eks-node-group-capacity-type-no-drift branch December 2, 2020 22:02
anGie44 added a commit that referenced this pull request Dec 2, 2020
@ghost
Copy link

ghost commented Dec 3, 2020

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

capacity_type introduced on aws_eks_node_group is forcing recreation in v3.19.0
2 participants