r/aws_s3_bucket: Add support for S3 Bucket Keys #16581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/M
github-actions
bot
added
the
needs-triage
mattburgess
force-pushed
the
s3_bucket_key
branch
from
d3e68e2
to
5376ff7
Compare
|
@mattburgess Thanks for the contribution. |
ewbankkit
added
waiting-response
|
Ran acceptance tests: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_\|TestAccAWSS3BucketObject_' ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 3 -run=TestAccAWSS3Bucket_\|TestAccAWSS3BucketObject_ -timeout 120m
=== RUN TestAccAWSS3BucketObject_noNameNoKey
=== PAUSE TestAccAWSS3BucketObject_noNameNoKey
=== RUN TestAccAWSS3BucketObject_empty
=== PAUSE TestAccAWSS3BucketObject_empty
=== RUN TestAccAWSS3BucketObject_source
=== PAUSE TestAccAWSS3BucketObject_source
=== RUN TestAccAWSS3BucketObject_content
=== PAUSE TestAccAWSS3BucketObject_content
=== RUN TestAccAWSS3BucketObject_etagEncryption
=== PAUSE TestAccAWSS3BucketObject_etagEncryption
=== RUN TestAccAWSS3BucketObject_contentBase64
=== PAUSE TestAccAWSS3BucketObject_contentBase64
=== RUN TestAccAWSS3BucketObject_withContentCharacteristics
=== PAUSE TestAccAWSS3BucketObject_withContentCharacteristics
=== RUN TestAccAWSS3BucketObject_NonVersioned
=== PAUSE TestAccAWSS3BucketObject_NonVersioned
=== RUN TestAccAWSS3BucketObject_updates
=== PAUSE TestAccAWSS3BucketObject_updates
=== RUN TestAccAWSS3BucketObject_updateSameFile
=== PAUSE TestAccAWSS3BucketObject_updateSameFile
=== RUN TestAccAWSS3BucketObject_updatesWithVersioning
=== PAUSE TestAccAWSS3BucketObject_updatesWithVersioning
=== RUN TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint
=== PAUSE TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint
=== RUN TestAccAWSS3BucketObject_kms
=== PAUSE TestAccAWSS3BucketObject_kms
=== RUN TestAccAWSS3BucketObject_sse
=== PAUSE TestAccAWSS3BucketObject_sse
=== RUN TestAccAWSS3BucketObject_acl
=== PAUSE TestAccAWSS3BucketObject_acl
=== RUN TestAccAWSS3BucketObject_metadata
=== PAUSE TestAccAWSS3BucketObject_metadata
=== RUN TestAccAWSS3BucketObject_storageClass
=== PAUSE TestAccAWSS3BucketObject_storageClass
=== RUN TestAccAWSS3BucketObject_tags
=== PAUSE TestAccAWSS3BucketObject_tags
=== RUN TestAccAWSS3BucketObject_tagsLeadingSlash
=== PAUSE TestAccAWSS3BucketObject_tagsLeadingSlash
=== RUN TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone
=== PAUSE TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone
=== RUN TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn
=== PAUSE TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn
=== RUN TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone
=== PAUSE TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone
=== RUN TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet
=== PAUSE TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet
=== RUN TestAccAWSS3BucketObject_bucketKeyEnabled
=== PAUSE TestAccAWSS3BucketObject_bucketKeyEnabled
=== RUN TestAccAWSS3BucketObject_defaultBucketSSE
=== PAUSE TestAccAWSS3BucketObject_defaultBucketSSE
=== RUN TestAccAWSS3BucketObject_ignoreTags
=== PAUSE TestAccAWSS3BucketObject_ignoreTags
=== RUN TestAccAWSS3Bucket_basic
=== PAUSE TestAccAWSS3Bucket_basic
=== RUN TestAccAWSS3Bucket_Bucket_EmptyString
=== PAUSE TestAccAWSS3Bucket_Bucket_EmptyString
=== RUN TestAccAWSS3Bucket_tagsWithNoSystemTags
=== PAUSE TestAccAWSS3Bucket_tagsWithNoSystemTags
=== RUN TestAccAWSS3Bucket_tagsWithSystemTags
=== PAUSE TestAccAWSS3Bucket_tagsWithSystemTags
=== RUN TestAccAWSS3Bucket_ignoreTags
=== PAUSE TestAccAWSS3Bucket_ignoreTags
=== RUN TestAccAWSS3Bucket_namePrefix
=== PAUSE TestAccAWSS3Bucket_namePrefix
=== RUN TestAccAWSS3Bucket_generatedName
=== PAUSE TestAccAWSS3Bucket_generatedName
=== RUN TestAccAWSS3Bucket_acceleration
=== PAUSE TestAccAWSS3Bucket_acceleration
=== RUN TestAccAWSS3Bucket_RequestPayer
=== PAUSE TestAccAWSS3Bucket_RequestPayer
=== RUN TestAccAWSS3Bucket_Policy
=== PAUSE TestAccAWSS3Bucket_Policy
=== RUN TestAccAWSS3Bucket_UpdateAcl
=== PAUSE TestAccAWSS3Bucket_UpdateAcl
=== RUN TestAccAWSS3Bucket_UpdateGrant
=== PAUSE TestAccAWSS3Bucket_UpdateGrant
=== RUN TestAccAWSS3Bucket_AclToGrant
=== PAUSE TestAccAWSS3Bucket_AclToGrant
=== RUN TestAccAWSS3Bucket_GrantToAcl
=== PAUSE TestAccAWSS3Bucket_GrantToAcl
=== RUN TestAccAWSS3Bucket_Website_Simple
=== PAUSE TestAccAWSS3Bucket_Website_Simple
=== RUN TestAccAWSS3Bucket_WebsiteRedirect
=== PAUSE TestAccAWSS3Bucket_WebsiteRedirect
=== RUN TestAccAWSS3Bucket_WebsiteRoutingRules
=== PAUSE TestAccAWSS3Bucket_WebsiteRoutingRules
=== RUN TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical
=== PAUSE TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical
=== RUN TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed
=== PAUSE TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed
=== RUN TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled
=== PAUSE TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled
=== RUN TestAccAWSS3Bucket_bucketKeyEnabled
=== PAUSE TestAccAWSS3Bucket_bucketKeyEnabled
=== RUN TestAccAWSS3Bucket_shouldFailNotFound
=== PAUSE TestAccAWSS3Bucket_shouldFailNotFound
=== RUN TestAccAWSS3Bucket_Versioning
=== PAUSE TestAccAWSS3Bucket_Versioning
=== RUN TestAccAWSS3Bucket_Cors_Update
=== PAUSE TestAccAWSS3Bucket_Cors_Update
=== RUN TestAccAWSS3Bucket_Cors_Delete
=== PAUSE TestAccAWSS3Bucket_Cors_Delete
=== RUN TestAccAWSS3Bucket_Cors_EmptyOrigin
=== PAUSE TestAccAWSS3Bucket_Cors_EmptyOrigin
=== RUN TestAccAWSS3Bucket_Logging
=== PAUSE TestAccAWSS3Bucket_Logging
=== RUN TestAccAWSS3Bucket_LifecycleBasic
=== PAUSE TestAccAWSS3Bucket_LifecycleBasic
=== RUN TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== PAUSE TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
=== RUN TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock
=== PAUSE TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock
=== RUN TestAccAWSS3Bucket_LifecycleRule_AbortIncompleteMultipartUploadDays_NoExpiration
=== PAUSE TestAccAWSS3Bucket_LifecycleRule_AbortIncompleteMultipartUploadDays_NoExpiration
=== RUN TestAccAWSS3Bucket_Replication
=== PAUSE TestAccAWSS3Bucket_Replication
=== RUN TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation
=== PAUSE TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation
=== RUN TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation
=== PAUSE TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation
=== RUN TestAccAWSS3Bucket_ReplicationWithoutStorageClass
=== PAUSE TestAccAWSS3Bucket_ReplicationWithoutStorageClass
=== RUN TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
=== PAUSE TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
=== RUN TestAccAWSS3Bucket_ReplicationWithoutPrefix
=== PAUSE TestAccAWSS3Bucket_ReplicationWithoutPrefix
=== RUN TestAccAWSS3Bucket_ReplicationSchemaV2
=== PAUSE TestAccAWSS3Bucket_ReplicationSchemaV2
=== RUN TestAccAWSS3Bucket_SameRegionReplicationSchemaV2
=== PAUSE TestAccAWSS3Bucket_SameRegionReplicationSchemaV2
=== RUN TestAccAWSS3Bucket_objectLock
=== PAUSE TestAccAWSS3Bucket_objectLock
=== RUN TestAccAWSS3Bucket_forceDestroy
=== PAUSE TestAccAWSS3Bucket_forceDestroy
=== RUN TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes
=== PAUSE TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes
=== RUN TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled
=== PAUSE TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled
=== CONT TestAccAWSS3BucketObject_noNameNoKey
=== CONT TestAccAWSS3Bucket_UpdateAcl
=== CONT TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (2.87s)
=== CONT TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (23.08s)
=== CONT TestAccAWSS3Bucket_forceDestroy
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (28.69s)
=== CONT TestAccAWSS3Bucket_objectLock
--- PASS: TestAccAWSS3Bucket_forceDestroy (22.79s)
=== CONT TestAccAWSS3Bucket_SameRegionReplicationSchemaV2
--- PASS: TestAccAWSS3Bucket_UpdateAcl (50.36s)
=== CONT TestAccAWSS3Bucket_ReplicationSchemaV2
--- PASS: TestAccAWSS3Bucket_objectLock (50.98s)
=== CONT TestAccAWSS3Bucket_ReplicationWithoutPrefix
--- PASS: TestAccAWSS3Bucket_SameRegionReplicationSchemaV2 (44.55s)
=== CONT TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (11.31s)
=== CONT TestAccAWSS3Bucket_ReplicationWithoutStorageClass
2020/12/05 18:02:38 [DEBUG] Waiting for state to become: [success]
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (38.56s)
=== CONT TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (36.81s)
=== CONT TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (126.35s)
=== CONT TestAccAWSS3Bucket_Replication
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation (68.66s)
=== CONT TestAccAWSS3Bucket_LifecycleRule_AbortIncompleteMultipartUploadDays_NoExpiration
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (65.56s)
=== CONT TestAccAWSS3Bucket_generatedName
--- PASS: TestAccAWSS3Bucket_LifecycleRule_AbortIncompleteMultipartUploadDays_NoExpiration (28.45s)
=== CONT TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock
--- PASS: TestAccAWSS3Bucket_generatedName (28.14s)
=== CONT TestAccAWSS3Bucket_LifecycleExpireMarkerOnly
--- PASS: TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock (23.30s)
=== CONT TestAccAWSS3Bucket_LifecycleBasic
resource_aws_s3_bucket_test.go:1271: Step 3/4 error: Check failed: Check 5/14 error: aws_s3_bucket.bucket: Attribute 'lifecycle_rule.0.noncurrent_version_expiration.0.days' not found
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (42.14s)
=== CONT TestAccAWSS3Bucket_Logging
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (53.08s)
=== CONT TestAccAWSS3Bucket_Cors_EmptyOrigin
--- PASS: TestAccAWSS3Bucket_Replication (120.40s)
=== CONT TestAccAWSS3Bucket_Cors_Delete
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (27.76s)
=== CONT TestAccAWSS3Bucket_Cors_Update
--- PASS: TestAccAWSS3Bucket_Cors_Delete (22.70s)
=== CONT TestAccAWSS3Bucket_Versioning
--- PASS: TestAccAWSS3Bucket_Logging (40.26s)
=== CONT TestAccAWSS3Bucket_shouldFailNotFound
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (13.73s)
=== CONT TestAccAWSS3Bucket_bucketKeyEnabled
--- PASS: TestAccAWSS3Bucket_bucketKeyEnabled (30.83s)
=== CONT TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled
--- PASS: TestAccAWSS3Bucket_Cors_Update (52.94s)
=== CONT TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed
--- PASS: TestAccAWSS3Bucket_Versioning (75.85s)
=== CONT TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (26.99s)
=== CONT TestAccAWSS3Bucket_WebsiteRoutingRules
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (51.60s)
=== CONT TestAccAWSS3Bucket_WebsiteRedirect
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (32.66s)
=== CONT TestAccAWSS3Bucket_Website_Simple
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (57.30s)
=== CONT TestAccAWSS3Bucket_GrantToAcl
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (75.49s)
=== CONT TestAccAWSS3Bucket_AclToGrant
--- PASS: TestAccAWSS3Bucket_GrantToAcl (46.49s)
=== CONT TestAccAWSS3Bucket_UpdateGrant
--- PASS: TestAccAWSS3Bucket_Website_Simple (74.38s)
=== CONT TestAccAWSS3Bucket_Policy
--- PASS: TestAccAWSS3Bucket_AclToGrant (46.08s)
=== CONT TestAccAWSS3Bucket_RequestPayer
--- PASS: TestAccAWSS3Bucket_Policy (77.64s)
=== CONT TestAccAWSS3Bucket_acceleration
--- PASS: TestAccAWSS3Bucket_UpdateGrant (81.63s)
=== CONT TestAccAWSS3Bucket_namePrefix
--- PASS: TestAccAWSS3Bucket_RequestPayer (51.27s)
=== CONT TestAccAWSS3Bucket_ignoreTags
=== CONT TestAccAWSS3Bucket_tagsWithSystemTags
--- PASS: TestAccAWSS3Bucket_namePrefix (27.03s)
--- PASS: TestAccAWSS3Bucket_acceleration (53.35s)
=== CONT TestAccAWSS3Bucket_tagsWithNoSystemTags
--- PASS: TestAccAWSS3Bucket_ignoreTags (46.61s)
=== CONT TestAccAWSS3Bucket_Bucket_EmptyString
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (27.27s)
=== CONT TestAccAWSS3Bucket_basic
=== CONT TestAccAWSS3BucketObject_ignoreTags
--- PASS: TestAccAWSS3Bucket_basic (27.07s)
=== CONT TestAccAWSS3BucketObject_ignoreTags
resource_aws_s3_bucket_object_test.go:1008: Step 1/2 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
stdout
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_s3_bucket_object.object will be updated in-place
~ resource "aws_s3_bucket_object" "object" {
acl = "private"
bucket = "tf-object-test-bucket-8337720210868131439"
bucket_key_enabled = false
content = "stuff"
content_type = "binary/octet-stream"
etag = "c13d88cb4cb02003daedb8a84e5d272a"
force_destroy = false
id = "test-key"
key = "test-key"
metadata = {}
storage_class = "STANDARD"
~ tags = {
- "ignorekey1" = "ignorevalue1" -> null
}
version_id = "WtLzAXLIAW6NxwJ2BixodtU9vwESz34U"
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSS3BucketObject_ignoreTags (25.03s)
=== CONT TestAccAWSS3BucketObject_defaultBucketSSE
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (101.09s)
=== CONT TestAccAWSS3BucketObject_bucketKeyEnabled
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (28.23s)
=== CONT TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (140.54s)
=== CONT TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone
--- PASS: TestAccAWSS3BucketObject_bucketKeyEnabled (24.06s)
=== CONT TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn
=== CONT TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (44.91s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (65.94s)
=== CONT TestAccAWSS3BucketObject_tagsLeadingSlash
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (87.14s)
=== CONT TestAccAWSS3BucketObject_tags
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (68.11s)
=== CONT TestAccAWSS3BucketObject_storageClass
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (87.25s)
=== CONT TestAccAWSS3BucketObject_metadata
--- PASS: TestAccAWSS3BucketObject_tags (87.69s)
=== CONT TestAccAWSS3BucketObject_acl
2020/12/05 18:16:27 [DEBUG] Waiting for state to become: [success]
--- PASS: TestAccAWSS3BucketObject_metadata (65.04s)
=== CONT TestAccAWSS3BucketObject_sse
--- PASS: TestAccAWSS3BucketObject_storageClass (106.81s)
=== CONT TestAccAWSS3BucketObject_kms
--- PASS: TestAccAWSS3BucketObject_acl (67.07s)
=== CONT TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint
=== CONT TestAccAWSS3BucketObject_updatesWithVersioning
--- PASS: TestAccAWSS3BucketObject_sse (23.09s)
--- PASS: TestAccAWSS3BucketObject_kms (25.60s)
=== CONT TestAccAWSS3BucketObject_updateSameFile
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (46.64s)
=== CONT TestAccAWSS3BucketObject_updates
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (51.72s)
=== CONT TestAccAWSS3BucketObject_NonVersioned
provider_test.go:1785: skipping tests; TF_ACC_ASSUME_ROLE_ARN must be set
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (0.00s)
=== CONT TestAccAWSS3BucketObject_withContentCharacteristics
--- PASS: TestAccAWSS3BucketObject_updateSameFile (44.57s)
=== CONT TestAccAWSS3BucketObject_contentBase64
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (23.14s)
=== CONT TestAccAWSS3BucketObject_etagEncryption
--- PASS: TestAccAWSS3BucketObject_contentBase64 (23.64s)
=== CONT TestAccAWSS3BucketObject_content
--- PASS: TestAccAWSS3BucketObject_updates (44.71s)
=== CONT TestAccAWSS3BucketObject_source
--- PASS: TestAccAWSS3BucketObject_etagEncryption (23.09s)
=== CONT TestAccAWSS3BucketObject_empty
--- PASS: TestAccAWSS3BucketObject_content (22.89s)
--- PASS: TestAccAWSS3BucketObject_source (22.48s)
--- PASS: TestAccAWSS3BucketObject_empty (22.90s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 1107.473s
FAIL
GNUmakefile:27: recipe for target 'testacc' failed
make: *** [testacc] Error 1I'll investigate the failures, especially the |
mattburgess
force-pushed
the
s3_bucket_key
branch
from
ac2e834
to
751ed5b
Compare
ghost
added
size/L
|
Thanks for the review @ewbankkit - the datasource is covered now. The acceptance tests for that are even worse though :( All the tests prior to It looks like a timing issue, almost like the object creation API hasn't been waited on at all/for long enough. I'm taking a look to see if I can figure out what's going on with those. |
ghost
removed
the
waiting-response
|
Yes, definitely something weird going on here. $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3BucketObject_ignoreTags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3BucketObject_ignoreTags -timeout 120m
=== RUN TestAccAWSS3BucketObject_ignoreTags
=== PAUSE TestAccAWSS3BucketObject_ignoreTags
=== CONT TestAccAWSS3BucketObject_ignoreTags
--- PASS: TestAccAWSS3BucketObject_ignoreTags (46.54s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 46.627s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_LifecycleBasic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_LifecycleBasic -timeout 120m
=== RUN TestAccAWSS3Bucket_LifecycleBasic
=== PAUSE TestAccAWSS3Bucket_LifecycleBasic
=== CONT TestAccAWSS3Bucket_LifecycleBasic
--- PASS: TestAccAWSS3Bucket_LifecycleBasic (74.95s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 75.036s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_LifecycleBasic\|TestAccAWSS3BucketObject_ignoreTags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_LifecycleBasic\|TestAccAWSS3BucketObject_ignoreTags -timeout 120m
=== RUN TestAccAWSS3BucketObject_ignoreTags
=== PAUSE TestAccAWSS3BucketObject_ignoreTags
=== RUN TestAccAWSS3Bucket_LifecycleBasic
=== PAUSE TestAccAWSS3Bucket_LifecycleBasic
=== CONT TestAccAWSS3BucketObject_ignoreTags
=== CONT TestAccAWSS3Bucket_LifecycleBasic
=== CONT TestAccAWSS3BucketObject_ignoreTags
resource_aws_s3_bucket_object_test.go:986: Step 1/2 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
stdout
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_s3_bucket_object.object will be updated in-place
~ resource "aws_s3_bucket_object" "object" {
acl = "private"
bucket = "tf-object-test-bucket-5373189707280510230"
content = "stuff"
content_type = "binary/octet-stream"
etag = "c13d88cb4cb02003daedb8a84e5d272a"
force_destroy = false
id = "test-key"
key = "test-key"
metadata = {}
storage_class = "STANDARD"
~ tags = {
- "ignorekey1" = "ignorevalue1" -> null
}
version_id = "XcSYGe3axWoSxPu7lAAgdASZ9b7MFIyw"
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSS3BucketObject_ignoreTags (26.71s)
=== CONT TestAccAWSS3Bucket_LifecycleBasic
resource_aws_s3_bucket_test.go:1240: Step 3/4 error: Check failed: Check 5/14 error: aws_s3_bucket.bucket: Attribute 'lifecycle_rule.0.noncurrent_version_expiration.0.days' not found
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (45.03s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 45.126s
FAIL
GNUmakefile:27: recipe for target 'testacc' failed
make: *** [testacc] Error 1On your branch: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_LifecycleBasic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_LifecycleBasic -timeout 120m
=== RUN TestAccAWSS3Bucket_LifecycleBasic
=== PAUSE TestAccAWSS3Bucket_LifecycleBasic
=== CONT TestAccAWSS3Bucket_LifecycleBasic
--- PASS: TestAccAWSS3Bucket_LifecycleBasic (76.00s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 76.056s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3BucketObject_ignoreTags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3BucketObject_ignoreTags -timeout 120m
=== RUN TestAccAWSS3BucketObject_ignoreTags
=== PAUSE TestAccAWSS3BucketObject_ignoreTags
=== CONT TestAccAWSS3BucketObject_ignoreTags
--- PASS: TestAccAWSS3BucketObject_ignoreTags (46.60s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 46.653s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSS3Bucket_LifecycleBasic\|TestAccAWSS3BucketObject_ignoreTags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSS3Bucket_LifecycleBasic\|TestAccAWSS3BucketObject_ignoreTags -timeout 120m
=== RUN TestAccAWSS3BucketObject_ignoreTags
=== PAUSE TestAccAWSS3BucketObject_ignoreTags
=== RUN TestAccAWSS3Bucket_LifecycleBasic
=== PAUSE TestAccAWSS3Bucket_LifecycleBasic
=== CONT TestAccAWSS3BucketObject_ignoreTags
=== CONT TestAccAWSS3Bucket_LifecycleBasic
=== CONT TestAccAWSS3BucketObject_ignoreTags
resource_aws_s3_bucket_object_test.go:1008: Step 1/2 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
stdout
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_s3_bucket_object.object will be updated in-place
~ resource "aws_s3_bucket_object" "object" {
acl = "private"
bucket = "tf-object-test-bucket-5434405205003282873"
bucket_key_enabled = false
content = "stuff"
content_type = "binary/octet-stream"
etag = "c13d88cb4cb02003daedb8a84e5d272a"
force_destroy = false
id = "test-key"
key = "test-key"
metadata = {}
storage_class = "STANDARD"
~ tags = {
- "ignorekey1" = "ignorevalue1" -> null
}
version_id = "NMQrW6U3UgBtohUqJ3AsgKaE0mg1irgs"
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSS3BucketObject_ignoreTags (26.41s)
=== CONT TestAccAWSS3Bucket_LifecycleBasic
resource_aws_s3_bucket_test.go:1271: Step 3/4 error: Check failed: Check 5/14 error: aws_s3_bucket.bucket: Attribute 'lifecycle_rule.0.noncurrent_version_expiration.0.days' not found
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (43.94s)
FAIL
FAIL github.com/terraform-providers/terraform-provider-aws/aws 43.996s
FAIL
GNUmakefile:27: recipe for target 'testacc' failed
make: *** [testacc] Error 1Tests run in parallel are failing. |
|
Hello @mattburgess and @ewbankkit , is there an ETA for this to be merged? We would really like this to be available in TF. |
mattburgess
force-pushed
the
s3_bucket_key
branch
from
751ed5b
to
ede2e77
Compare
@aperagalloc I'm just a contributor so can't provide an ETA on when this might be merged. I've just rebased this PR against the latest |
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
For now, I had implemented this hack to move forward. resource "null_resource" "s3_bucket_sse_config" {
depends_on = [aws_s3_bucket.s3_bucket]
triggers = {
s3_bucket = aws_s3_bucket.s3_bucket.id
}
provisioner "local-exec" {
command = "aws s3api put-bucket-encryption --bucket --server-side-encryption-configuration '{\"Rules\": [{\"ApplyServerSideEncryptionByDefault\":{\"SSEAlgorithm\": \"aws:kms\",\"KMSMasterKeyID\":\"${aws_kms_key.kms_key.arn}\"},\"BucketKeyEnabled\": true}]}'"
}
}
|
bflad
added
the
enhancement
bflad
suggested changes
Mar 31, 2021
There was a problem hiding this comment.
Hi @mattburgess 👋 Thank you for your work on this. Overall, this is looking good. Just one definite fix and question about what happens when the Bucket has this enabled but the Object doesn't. Cheers!
bflad
added
the
waiting-response
Closed
bflad
reviewed
Mar 31, 2021
mattburgess
force-pushed
the
s3_bucket_key
branch
from
ede2e77
to
1229578
Compare
|
FYI, all tests passing nicely now: |
ghost
removed
the
waiting-response
mattburgess
force-pushed
the
s3_bucket_key
branch
from
1229578
to
8a28e41
Compare
|
Thanks so much, @mattburgess! 😄 Will take a peek at this shortly. |
bflad
approved these changes
Apr 2, 2021
There was a problem hiding this comment.
Looks great! 🚀
Output from acceptance testing in AWS Commercial:
--- PASS: TestAccAWSS3Bucket_acceleration (77.72s)
--- PASS: TestAccAWSS3Bucket_AclToGrant (67.81s)
--- PASS: TestAccAWSS3Bucket_basic (43.99s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (44.40s)
--- PASS: TestAccAWSS3Bucket_bucketKeyEnabled (43.09s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (31.97s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (40.73s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (75.47s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (71.37s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (40.40s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (43.33s)
--- PASS: TestAccAWSS3Bucket_forceDestroy (31.28s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (34.81s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (37.66s)
--- PASS: TestAccAWSS3Bucket_generatedName (37.26s)
--- PASS: TestAccAWSS3Bucket_GrantToAcl (68.73s)
--- PASS: TestAccAWSS3Bucket_ignoreTags (68.51s)
--- PASS: TestAccAWSS3Bucket_LifecycleBasic (91.66s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (71.82s)
--- PASS: TestAccAWSS3Bucket_LifecycleRule_AbortIncompleteMultipartUploadDays_NoExpiration (38.91s)
--- PASS: TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock (31.06s)
--- PASS: TestAccAWSS3Bucket_Logging (63.26s)
--- PASS: TestAccAWSS3Bucket_namePrefix (46.80s)
--- PASS: TestAccAWSS3Bucket_objectLock (68.55s)
--- PASS: TestAccAWSS3Bucket_Policy (100.51s)
--- PASS: TestAccAWSS3Bucket_Replication (141.65s)
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter (49.89s)
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter (49.86s)
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_TwoDestination (46.15s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (87.62s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation (86.86s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (14.78s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (163.32s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (51.27s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (45.50s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (70.57s)
--- PASS: TestAccAWSS3Bucket_SameRegionReplicationSchemaV2 (56.90s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (20.04s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (140.95s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (177.22s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (78.18s)
--- PASS: TestAccAWSS3Bucket_UpdateGrant (108.69s)
--- PASS: TestAccAWSS3Bucket_Versioning (103.73s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (106.81s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (110.01s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (73.38s)
--- PASS: TestAccAWSS3BucketObject_acl (97.64s)
--- PASS: TestAccAWSS3BucketObject_bucketBucketKeyEnabled (47.14s)
--- PASS: TestAccAWSS3BucketObject_content (33.47s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (31.68s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (40.86s)
--- PASS: TestAccAWSS3BucketObject_empty (32.54s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (33.10s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (69.05s)
--- PASS: TestAccAWSS3BucketObject_kms (38.94s)
--- PASS: TestAccAWSS3BucketObject_metadata (90.62s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (2.10s)
--- PASS: TestAccAWSS3BucketObject_NonVersioned (31.53s)
--- PASS: TestAccAWSS3BucketObject_objectBucketKeyEnabled (38.89s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (91.67s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (60.02s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (92.71s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (116.24s)
--- PASS: TestAccAWSS3BucketObject_source (33.40s)
--- PASS: TestAccAWSS3BucketObject_sse (38.30s)
--- PASS: TestAccAWSS3BucketObject_storageClass (150.35s)
--- PASS: TestAccAWSS3BucketObject_tags (123.37s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (126.89s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (126.64s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (117.47s)
--- PASS: TestAccAWSS3BucketObject_updates (60.84s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (60.72s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (61.90s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (76.09s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (31.05s)
--- PASS: TestAccDataSourceAWSS3BucketObject_allParams (37.71s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basic (39.61s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basicViaAccessPoint (39.30s)
--- PASS: TestAccDataSourceAWSS3BucketObject_bucketKeyEnabled (41.45s)
--- PASS: TestAccDataSourceAWSS3BucketObject_kmsEncrypted (38.94s)
--- PASS: TestAccDataSourceAWSS3BucketObject_LeadingSlash (67.65s)
--- PASS: TestAccDataSourceAWSS3BucketObject_MultipleSlashes (66.64s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOff (37.55s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOn (38.33s)
--- PASS: TestAccDataSourceAWSS3BucketObject_readableBody (35.63s)
--- PASS: TestAccDataSourceAWSS3BucketObject_SingleSlashAsKey (31.84s)
Output from acceptance testing in AWS GovCloud (US):
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (45.90s) # https://github.com/hashicorp/terraform-provider-aws/issues/18511
--- PASS: TestAccAWSS3Bucket_AclToGrant (72.45s)
--- PASS: TestAccAWSS3Bucket_basic (39.51s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (40.99s)
--- PASS: TestAccAWSS3Bucket_bucketKeyEnabled (57.24s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (33.66s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (43.24s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (76.55s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (83.35s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (50.07s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (59.66s)
--- PASS: TestAccAWSS3Bucket_forceDestroy (41.90s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (41.74s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (43.77s)
--- PASS: TestAccAWSS3Bucket_generatedName (39.92s)
--- PASS: TestAccAWSS3Bucket_GrantToAcl (76.18s)
--- PASS: TestAccAWSS3Bucket_ignoreTags (69.36s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (52.92s)
--- PASS: TestAccAWSS3Bucket_LifecycleRule_AbortIncompleteMultipartUploadDays_NoExpiration (42.01s)
--- PASS: TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock (33.30s)
--- PASS: TestAccAWSS3Bucket_Logging (54.19s)
--- PASS: TestAccAWSS3Bucket_namePrefix (41.12s)
--- PASS: TestAccAWSS3Bucket_objectLock (82.24s)
--- PASS: TestAccAWSS3Bucket_Policy (109.36s)
--- PASS: TestAccAWSS3Bucket_Replication (167.07s)
--- PASS: TestAccAWSS3Bucket_Replication_MultipleDestinations_TwoDestination (64.85s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (105.07s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation (68.50s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (21.57s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (177.48s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (64.72s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (51.92s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (79.18s)
--- PASS: TestAccAWSS3Bucket_SameRegionReplicationSchemaV2 (70.20s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (28.74s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (146.42s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (195.57s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (69.73s)
--- PASS: TestAccAWSS3Bucket_UpdateGrant (113.18s)
--- PASS: TestAccAWSS3Bucket_Versioning (110.36s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (105.63s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (122.37s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (83.63s)
--- SKIP: TestAccAWSS3Bucket_acceleration (0.00s)
--- SKIP: TestAccAWSS3Bucket_Replication_MultipleDestinations_EmptyFilter (31.31s)
--- SKIP: TestAccAWSS3Bucket_Replication_MultipleDestinations_NonEmptyFilter (29.41s)
--- PASS: TestAccAWSS3BucketObject_acl (80.47s)
--- PASS: TestAccAWSS3BucketObject_bucketBucketKeyEnabled (43.37s)
--- PASS: TestAccAWSS3BucketObject_content (35.12s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (33.84s)
--- PASS: TestAccAWSS3BucketObject_defaultBucketSSE (43.09s)
--- PASS: TestAccAWSS3BucketObject_empty (36.84s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (34.47s)
--- PASS: TestAccAWSS3BucketObject_ignoreTags (68.34s)
--- PASS: TestAccAWSS3BucketObject_kms (32.07s)
--- PASS: TestAccAWSS3BucketObject_metadata (78.86s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (3.25s)
--- PASS: TestAccAWSS3BucketObject_objectBucketKeyEnabled (35.73s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (94.04s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (69.24s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (90.95s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (122.98s)
--- PASS: TestAccAWSS3BucketObject_source (34.57s)
--- PASS: TestAccAWSS3BucketObject_sse (31.84s)
--- PASS: TestAccAWSS3BucketObject_storageClass (126.89s)
--- PASS: TestAccAWSS3BucketObject_tags (111.75s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingMultipleSlashes (117.49s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSingleSlash (115.91s)
--- PASS: TestAccAWSS3BucketObject_tagsMultipleSlashes (114.99s)
--- PASS: TestAccAWSS3BucketObject_updates (69.26s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (66.18s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (67.47s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (70.95s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (33.42s)
--- SKIP: TestAccAWSS3BucketObject_NonVersioned (0.05s)
--- PASS: TestAccDataSourceAWSS3BucketObject_allParams (38.87s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basic (42.58s)
--- PASS: TestAccDataSourceAWSS3BucketObject_basicViaAccessPoint (38.88s)
--- PASS: TestAccDataSourceAWSS3BucketObject_bucketKeyEnabled (38.86s)
--- PASS: TestAccDataSourceAWSS3BucketObject_kmsEncrypted (41.60s)
--- PASS: TestAccDataSourceAWSS3BucketObject_LeadingSlash (72.16s)
--- PASS: TestAccDataSourceAWSS3BucketObject_MultipleSlashes (76.35s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOff (41.74s)
--- PASS: TestAccDataSourceAWSS3BucketObject_ObjectLockLegalHoldOn (38.42s)
--- PASS: TestAccDataSourceAWSS3BucketObject_readableBody (38.45s)
--- PASS: TestAccDataSourceAWSS3BucketObject_SingleSlashAsKey (34.70s)
|
This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
1 task
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #16536
Release note for CHANGELOG:
Output from acceptance testing:
All failures look like they're latent to me.