Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need ability to specify "on-demand" instance count for aws_spot_fleet_request resource #16607

Closed
ZillaG opened this issue Dec 5, 2020 · 3 comments · Fixed by #13127
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ZillaG
Copy link

ZillaG commented Dec 5, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

$ terraform -version
Terraform v0.12.17
+ provider.aws v3.2.0

I created an AWS launch template via the aws_launch_template resource, and am creating a spot fleet request using the template via the aws_spot_fleet_request resource.

In the AWS console, when creating a spot fleet request using a launch template, I have the option to specify on-demand instances.

However, I don't see that option in the aws_spot_fleet_request resource. So even though I'm able to create the spot fleet request, all of the instances are spot instances, and no on-demand instances. Can we add it please?

I posted Setting AWS on-demand instances using Terraform aws_spot_fleet_request resource using a launch_template? in Stackoverflow which has the screen shot of the AWS console option I mention.

New or Affected Resource(s)

  • aws_spot_fleet_request

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

  • #0000
@ZillaG ZillaG added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 5, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Dec 5, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 5, 2020
@anGie44 anGie44 removed the needs-triage Waiting for first response or review from a maintainer. label Dec 5, 2020
@DrFaust92
Copy link
Collaborator

Related #7011

@ZillaG
Copy link
Author

ZillaG commented Dec 6, 2020

Same as #13127

@ghost
Copy link

ghost commented Jan 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 5, 2021
@github-actions github-actions bot added this to the v3.46.0 milestone Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants