B aws ssm parameter arn

[kuroseets]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #16483

Release note for CHANGELOG:

Fixed arn being invalid when getting public parameters

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSsmParameterDataSource_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSsmParameterDataSource_* -timeout 120m
go: downloading github.com/aws/aws-sdk-go v1.36.0
=== RUN   TestAccAWSSsmParameterDataSource_basic
=== PAUSE TestAccAWSSsmParameterDataSource_basic
=== RUN   TestAccAWSSsmParameterDataSource_fullPath
=== PAUSE TestAccAWSSsmParameterDataSource_fullPath
=== CONT  TestAccAWSSsmParameterDataSource_basic
=== CONT  TestAccAWSSsmParameterDataSource_fullPath
--- PASS: TestAccAWSSsmParameterDataSource_fullPath (49.68s)
--- PASS: TestAccAWSSsmParameterDataSource_basic (84.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	88.299s

$ make testacc TESTARGS='-run=TestAccAWSSSMParameter_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMParameter_* -timeout 120m
=== RUN   TestAccAWSSSMParameter_basic
=== PAUSE TestAccAWSSSMParameter_basic
=== RUN   TestAccAWSSSMParameter_Tier
=== PAUSE TestAccAWSSSMParameter_Tier
=== RUN   TestAccAWSSSMParameter_disappears
=== PAUSE TestAccAWSSSMParameter_disappears
=== RUN   TestAccAWSSSMParameter_overwrite
=== PAUSE TestAccAWSSSMParameter_overwrite
=== RUN   TestAccAWSSSMParameter_tags
=== PAUSE TestAccAWSSSMParameter_tags
=== RUN   TestAccAWSSSMParameter_updateType
=== PAUSE TestAccAWSSSMParameter_updateType
=== RUN   TestAccAWSSSMParameter_updateDescription
=== PAUSE TestAccAWSSSMParameter_updateDescription
=== RUN   TestAccAWSSSMParameter_changeNameForcesNew
=== PAUSE TestAccAWSSSMParameter_changeNameForcesNew
=== RUN   TestAccAWSSSMParameter_fullPath
=== PAUSE TestAccAWSSSMParameter_fullPath
=== RUN   TestAccAWSSSMParameter_secure
=== PAUSE TestAccAWSSSMParameter_secure
=== RUN   TestAccAWSSSMParameter_DataType_AwsEc2Image
=== PAUSE TestAccAWSSSMParameter_DataType_AwsEc2Image
=== RUN   TestAccAWSSSMParameter_secure_with_key
=== PAUSE TestAccAWSSSMParameter_secure_with_key
=== RUN   TestAccAWSSSMParameter_secure_keyUpdate
=== PAUSE TestAccAWSSSMParameter_secure_keyUpdate
=== CONT  TestAccAWSSSMParameter_basic
=== CONT  TestAccAWSSSMParameter_changeNameForcesNew
=== CONT  TestAccAWSSSMParameter_DataType_AwsEc2Image
=== CONT  TestAccAWSSSMParameter_fullPath
=== CONT  TestAccAWSSSMParameter_secure_with_key
=== CONT  TestAccAWSSSMParameter_secure_keyUpdate
=== CONT  TestAccAWSSSMParameter_overwrite
=== CONT  TestAccAWSSSMParameter_tags
=== CONT  TestAccAWSSSMParameter_disappears
=== CONT  TestAccAWSSSMParameter_secure
=== CONT  TestAccAWSSSMParameter_Tier
=== CONT  TestAccAWSSSMParameter_updateDescription
=== CONT  TestAccAWSSSMParameter_updateType
--- PASS: TestAccAWSSSMParameter_disappears (145.27s)
--- PASS: TestAccAWSSSMParameter_fullPath (180.46s)
--- PASS: TestAccAWSSSMParameter_basic (186.11s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (190.38s)
--- PASS: TestAccAWSSSMParameter_secure (192.00s)
--- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (194.40s)
--- PASS: TestAccAWSSSMParameter_overwrite (247.66s)
--- PASS: TestAccAWSSSMParameter_updateDescription (254.56s)
--- PASS: TestAccAWSSSMParameter_updateType (254.65s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (255.14s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (257.10s)
--- PASS: TestAccAWSSSMParameter_Tier (281.40s)
--- PASS: TestAccAWSSSMParameter_tags (284.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	287.605s
...

[github-actions]

Welcome @kuroseets 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[bflad]

Thank you so much for this fix, @kuroseets 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSSMParameter_disappears (13.57s)
--- PASS: TestAccAWSSSMParameter_fullPath (20.63s)
--- PASS: TestAccAWSSSMParameter_secure (20.69s)
--- PASS: TestAccAWSSSMParameter_basic (20.79s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (25.14s)
--- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (27.44s)
--- PASS: TestAccAWSSSMParameter_updateType (30.41s)
--- PASS: TestAccAWSSSMParameter_overwrite (30.63s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (32.01s)
--- PASS: TestAccAWSSSMParameter_updateDescription (32.38s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (37.80s)
--- PASS: TestAccAWSSSMParameter_Tier (42.21s)
--- PASS: TestAccAWSSSMParameter_tags (43.21s)

--- PASS: TestAccAWSSsmParameterDataSource_fullPath (13.55s)
--- PASS: TestAccAWSSsmParameterDataSource_basic (23.59s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSSSMParameter_disappears (18.05s)
--- PASS: TestAccAWSSSMParameter_basic (22.14s)
--- PASS: TestAccAWSSSMParameter_fullPath (24.04s)
--- PASS: TestAccAWSSSMParameter_secure (25.08s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (29.76s)
--- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (31.17s)
--- PASS: TestAccAWSSSMParameter_updateType (38.74s)
--- PASS: TestAccAWSSSMParameter_updateDescription (39.26s)
--- PASS: TestAccAWSSSMParameter_overwrite (39.32s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (40.95s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (46.73s)
--- PASS: TestAccAWSSSMParameter_tags (54.20s)
--- PASS: TestAccAWSSSMParameter_Tier (55.50s)

--- PASS: TestAccAWSSsmParameterDataSource_fullPath (19.00s)
--- PASS: TestAccAWSSsmParameterDataSource_basic (32.81s)

[ghost]

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!