Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_launch_template: AWS Wavelength support #16707

Merged
merged 2 commits into from
Dec 11, 2020
Merged

aws_launch_template: AWS Wavelength support #16707

merged 2 commits into from
Dec 11, 2020

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 10, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #14518.

Release note for CHANGELOG:

resource/aws_launch_template: Add `associate_carrier_ip_address` attribute to `network_interfaces` configuration block.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplate_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSLaunchTemplate_ -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_basic
=== PAUSE TestAccAWSLaunchTemplate_basic
=== RUN   TestAccAWSLaunchTemplate_disappears
=== PAUSE TestAccAWSLaunchTemplate_disappears
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== RUN   TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== PAUSE TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
=== RUN   TestAccAWSLaunchTemplate_EbsOptimized
=== PAUSE TestAccAWSLaunchTemplate_EbsOptimized
=== RUN   TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== PAUSE TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
=== RUN   TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination
=== PAUSE TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination
=== RUN   TestAccAWSLaunchTemplate_data
=== PAUSE TestAccAWSLaunchTemplate_data
=== RUN   TestAccAWSLaunchTemplate_description
=== PAUSE TestAccAWSLaunchTemplate_description
=== RUN   TestAccAWSLaunchTemplate_update
=== PAUSE TestAccAWSLaunchTemplate_update
=== RUN   TestAccAWSLaunchTemplate_tags
=== PAUSE TestAccAWSLaunchTemplate_tags
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_preference
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_preference
=== RUN   TestAccAWSLaunchTemplate_capacityReservation_target
=== PAUSE TestAccAWSLaunchTemplate_capacityReservation_target
=== RUN   TestAccAWSLaunchTemplate_cpuOptions
=== PAUSE TestAccAWSLaunchTemplate_cpuOptions
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t2
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t2
=== RUN   TestAccAWSLaunchTemplate_creditSpecification_t3
=== PAUSE TestAccAWSLaunchTemplate_creditSpecification_t3
=== RUN   TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== PAUSE TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
=== RUN   TestAccAWSLaunchTemplate_networkInterface
=== PAUSE TestAccAWSLaunchTemplate_networkInterface
=== RUN   TestAccAWSLaunchTemplate_networkInterfaceAddresses
=== PAUSE TestAccAWSLaunchTemplate_networkInterfaceAddresses
=== RUN   TestAccAWSLaunchTemplate_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplate_associatePublicIPAddress
=== RUN   TestAccAWSLaunchTemplate_associateCarrierIPAddress
=== PAUSE TestAccAWSLaunchTemplate_associateCarrierIPAddress
=== RUN   TestAccAWSLaunchTemplate_placement_partitionNum
=== PAUSE TestAccAWSLaunchTemplate_placement_partitionNum
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
=== RUN   TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== PAUSE TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== RUN   TestAccAWSLaunchTemplate_instanceMarketOptions
=== PAUSE TestAccAWSLaunchTemplate_instanceMarketOptions
=== RUN   TestAccAWSLaunchTemplate_licenseSpecification
=== PAUSE TestAccAWSLaunchTemplate_licenseSpecification
=== RUN   TestAccAWSLaunchTemplate_metadataOptions
=== PAUSE TestAccAWSLaunchTemplate_metadataOptions
=== RUN   TestAccAWSLaunchTemplate_hibernation
=== PAUSE TestAccAWSLaunchTemplate_hibernation
=== RUN   TestAccAWSLaunchTemplate_defaultVersion
=== PAUSE TestAccAWSLaunchTemplate_defaultVersion
=== RUN   TestAccAWSLaunchTemplate_updateDefaultVersion
=== PAUSE TestAccAWSLaunchTemplate_updateDefaultVersion
=== CONT  TestAccAWSLaunchTemplate_basic
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t3
--- PASS: TestAccAWSLaunchTemplate_basic (14.95s)
=== CONT  TestAccAWSLaunchTemplate_updateDefaultVersion
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (15.23s)
=== CONT  TestAccAWSLaunchTemplate_defaultVersion
--- PASS: TestAccAWSLaunchTemplate_defaultVersion (34.84s)
=== CONT  TestAccAWSLaunchTemplate_hibernation
--- PASS: TestAccAWSLaunchTemplate_updateDefaultVersion (44.67s)
=== CONT  TestAccAWSLaunchTemplate_metadataOptions
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (13.45s)
=== CONT  TestAccAWSLaunchTemplate_licenseSpecification
--- PASS: TestAccAWSLaunchTemplate_hibernation (35.27s)
=== CONT  TestAccAWSLaunchTemplate_instanceMarketOptions
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (15.54s)
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount
=== CONT  TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (14.16s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (12.97s)
=== CONT  TestAccAWSLaunchTemplate_placement_partitionNum
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (27.10s)
=== CONT  TestAccAWSLaunchTemplate_associateCarrierIPAddress
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (57.91s)
=== CONT  TestAccAWSLaunchTemplate_associatePublicIPAddress
--- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (99.81s)
=== CONT  TestAccAWSLaunchTemplate_networkInterfaceAddresses
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (101.87s)
=== CONT  TestAccAWSLaunchTemplate_networkInterface
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (57.78s)
=== CONT  TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock
--- PASS: TestAccAWSLaunchTemplate_networkInterface (57.79s)
=== CONT  TestAccAWSLaunchTemplate_description
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (12.01s)
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_t2
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (13.82s)
=== CONT  TestAccAWSLaunchTemplate_creditSpecification_nonBurstable
--- PASS: TestAccAWSLaunchTemplate_description (25.01s)
=== CONT  TestAccAWSLaunchTemplate_cpuOptions
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (12.04s)
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_target
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (13.76s)
=== CONT  TestAccAWSLaunchTemplate_capacityReservation_preference
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (13.26s)
=== CONT  TestAccAWSLaunchTemplate_tags
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (17.40s)
=== CONT  TestAccAWSLaunchTemplate_update
--- PASS: TestAccAWSLaunchTemplate_tags (23.91s)
=== CONT  TestAccAWSLaunchTemplate_EbsOptimized
--- PASS: TestAccAWSLaunchTemplate_update (55.33s)
=== CONT  TestAccAWSLaunchTemplate_data
--- PASS: TestAccAWSLaunchTemplate_data (14.49s)
=== CONT  TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (53.42s)
=== CONT  TestAccAWSLaunchTemplate_ElasticInferenceAccelerator
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (24.00s)
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS
=== CONT  TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination
--- PASS: TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination (44.59s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (39.42s)
=== CONT  TestAccAWSLaunchTemplate_disappears
--- PASS: TestAccAWSLaunchTemplate_disappears (8.46s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (53.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	525.499s
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSLaunchTemplateDataSource_ -timeout 120m
=== RUN   TestAccAWSLaunchTemplateDataSource_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_basic
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_basic
=== RUN   TestAccAWSLaunchTemplateDataSource_filter_tags
=== PAUSE TestAccAWSLaunchTemplateDataSource_filter_tags
=== RUN   TestAccAWSLaunchTemplateDataSource_metadataOptions
=== PAUSE TestAccAWSLaunchTemplateDataSource_metadataOptions
=== RUN   TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
=== RUN   TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== RUN   TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== PAUSE TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
=== RUN   TestAccAWSLaunchTemplateDataSource_NonExistent
=== PAUSE TestAccAWSLaunchTemplateDataSource_NonExistent
=== CONT  TestAccAWSLaunchTemplateDataSource_basic
=== CONT  TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (14.99s)
=== CONT  TestAccAWSLaunchTemplateDataSource_NonExistent
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (1.75s)
=== CONT  TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination
--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (40.41s)
=== CONT  TestAccAWSLaunchTemplateDataSource_metadataOptions
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (13.50s)
=== CONT  TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (39.41s)
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_tags
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (13.04s)
=== CONT  TestAccAWSLaunchTemplateDataSource_filter_basic
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (13.57s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (38.85s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	92.861s

@ewbankkit
r/aws_launch_template: Add 'associate_carrier_ip_address' to 'network…
d705bfb 
…_interfaces' block.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplate_associateCarrierIPAddress'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLaunchTemplate_associateCarrierIPAddress -timeout 120m
=== RUN   TestAccAWSLaunchTemplate_associateCarrierIPAddress
=== PAUSE TestAccAWSLaunchTemplate_associateCarrierIPAddress
=== CONT  TestAccAWSLaunchTemplate_associateCarrierIPAddress
--- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (96.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	96.150s
@ewbankkit ewbankkit requested a review from a team as a code owner December 10, 2020 22:16
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 10, 2020
@ewbankkit
d/aws_launch_template: Add 'associate_carrier_ip_address' to 'network…
a8dda1c 
…_interfaces' block.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress -timeout 120m
=== RUN   TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== PAUSE TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
=== CONT  TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress
--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (38.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	38.329s
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Dec 10, 2020
@ewbankkit ewbankkit changed the title [WIP] aws_launch_template: AWS Wavelength support aws_launch_template: AWS Wavelength support Dec 10, 2020
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 11, 2020
@bflad bflad self-assigned this Dec 11, 2020
@bflad bflad added this to the v3.21.0 milestone Dec 11, 2020
bflad
bflad approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @ewbankkit 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (136.36s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (136.11s)
--- PASS: TestAccAWSLaunchTemplate_basic (43.54s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (66.15s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (110.45s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (40.17s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (50.13s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (40.18s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (41.89s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (43.47s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (42.05s)
--- PASS: TestAccAWSLaunchTemplate_data (44.75s)
--- PASS: TestAccAWSLaunchTemplate_defaultVersion (97.02s)
--- PASS: TestAccAWSLaunchTemplate_description (77.89s)
--- PASS: TestAccAWSLaunchTemplate_disappears (30.77s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (123.80s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (77.92s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (99.77s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (24.46s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (91.34s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (48.68s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (43.97s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (66.80s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (42.36s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (43.77s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (67.46s)
--- PASS: TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination (111.89s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (79.23s)
--- PASS: TestAccAWSLaunchTemplate_tags (77.60s)
--- PASS: TestAccAWSLaunchTemplate_update (94.80s)
--- PASS: TestAccAWSLaunchTemplate_updateDefaultVersion (110.73s)

--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (45.56s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (43.88s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (18.13s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (18.89s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (19.07s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (17.92s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (44.95s)
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (3.90s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSLaunchTemplate_associateCarrierIPAddress (115.16s)
--- PASS: TestAccAWSLaunchTemplate_associatePublicIPAddress (115.82s)
--- PASS: TestAccAWSLaunchTemplate_basic (50.75s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS (90.51s)
--- PASS: TestAccAWSLaunchTemplate_BlockDeviceMappings_EBS_DeleteOnTermination (87.41s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_preference (52.50s)
--- PASS: TestAccAWSLaunchTemplate_capacityReservation_target (53.88s)
--- PASS: TestAccAWSLaunchTemplate_cpuOptions (45.19s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_nonBurstable (51.26s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t2 (51.35s)
--- PASS: TestAccAWSLaunchTemplate_creditSpecification_t3 (54.08s)
--- PASS: TestAccAWSLaunchTemplate_data (53.52s)
--- PASS: TestAccAWSLaunchTemplate_defaultVersion (72.07s)
--- PASS: TestAccAWSLaunchTemplate_description (81.54s)
--- PASS: TestAccAWSLaunchTemplate_disappears (37.99s)
--- PASS: TestAccAWSLaunchTemplate_EbsOptimized (131.61s)
--- PASS: TestAccAWSLaunchTemplate_ElasticInferenceAccelerator (62.42s)
--- PASS: TestAccAWSLaunchTemplate_hibernation (102.01s)
--- PASS: TestAccAWSLaunchTemplate_IamInstanceProfile_EmptyConfigurationBlock (32.99s)
--- PASS: TestAccAWSLaunchTemplate_instanceMarketOptions (125.69s)
--- PASS: TestAccAWSLaunchTemplate_licenseSpecification (48.17s)
--- PASS: TestAccAWSLaunchTemplate_metadataOptions (51.43s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface (74.98s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6AddressCount (52.79s)
--- PASS: TestAccAWSLaunchTemplate_networkInterface_ipv6Addresses (38.08s)
--- PASS: TestAccAWSLaunchTemplate_networkInterfaceAddresses (73.79s)
--- PASS: TestAccAWSLaunchTemplate_NetworkInterfaces_DeleteOnTermination (114.72s)
--- PASS: TestAccAWSLaunchTemplate_placement_partitionNum (58.45s)
--- PASS: TestAccAWSLaunchTemplate_tags (79.26s)
--- PASS: TestAccAWSLaunchTemplate_update (106.69s)
--- PASS: TestAccAWSLaunchTemplate_updateDefaultVersion (88.62s)

--- PASS: TestAccAWSLaunchTemplateDataSource_associateCarrierIPAddress (55.30s)
--- PASS: TestAccAWSLaunchTemplateDataSource_associatePublicIPAddress (55.45s)
--- PASS: TestAccAWSLaunchTemplateDataSource_basic (23.72s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_basic (22.95s)
--- PASS: TestAccAWSLaunchTemplateDataSource_filter_tags (23.53s)
--- PASS: TestAccAWSLaunchTemplateDataSource_metadataOptions (21.69s)
--- PASS: TestAccAWSLaunchTemplateDataSource_networkInterfaces_deleteOnTermination (55.36s)
--- PASS: TestAccAWSLaunchTemplateDataSource_NonExistent (5.39s)

@bflad bflad merged commit 57d37d8 into hashicorp:master Dec 11, 2020
@ewbankkit ewbankkit deleted the f-aws_launch_template-associate_carrier_ip_address branch December 11, 2020 15:04
bflad added a commit that referenced this pull request Dec 11, 2020
@bflad
Update CHANGELOG for #16707
17ac50f
@ghost
Copy link

ghost commented Dec 11, 2020

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ewbankkit @bflad