Implement dynamodb kinesis streaming destination

[matthewrj]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16406

Release note for CHANGELOG:

Added resource for DynamoDB Kinesis streaming destination.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsDynamodbKinesisStreamingDestination'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDynamodbKinesisStreamingDestination -timeout 120m
=== RUN   TestAccAwsDynamodbKinesisStreamingDestination_basic
=== PAUSE TestAccAwsDynamodbKinesisStreamingDestination_basic
=== RUN   TestAccAwsDynamodbKinesisStreamingDestination_disappears
=== PAUSE TestAccAwsDynamodbKinesisStreamingDestination_disappears
=== RUN   TestAccAwsDynamodbKinesisStreamingDestination_disappears_DynamoTable
=== PAUSE TestAccAwsDynamodbKinesisStreamingDestination_disappears_DynamoTable
=== CONT  TestAccAwsDynamodbKinesisStreamingDestination_basic
=== CONT  TestAccAwsDynamodbKinesisStreamingDestination_disappears_DynamoTable
=== CONT  TestAccAwsDynamodbKinesisStreamingDestination_disappears
--- PASS: TestAccAwsDynamodbKinesisStreamingDestination_disappears_DynamoTable (99.76s)
--- PASS: TestAccAwsDynamodbKinesisStreamingDestination_disappears (100.39s)
--- PASS: TestAccAwsDynamodbKinesisStreamingDestination_basic (134.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	136.461s

[github-actions]

Welcome @matthewrj 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[matthewrj]

Would love an update on when we can expect this PR to be reviewed.

[barryoneill]

This PR is three months old now; Is there some outstanding issue with it that one of us could address to get it merged?

[nicolas-lopez]

Hello this PR has been open for almost 4 month every checks and tests are green. Is there any reason why this PR can't be merged ? This new feature would be really appreciated. Thanks for your work and time.

[barendb]

Adding a bump to this as well, Matt has put some good work into this, would ❤️ to see it landed...

[kgrits]

Hey, any updates on this? I would reaaaally love to have this merged 👍

[anGie44]

Hi @matthewrj , thank you for this PR and your patience! I'll be completing my review to get this in an upcoming release, but just wanted to drop a note to please push up a .changelog/16743.txt file with this PR in the meantime. thanks in advance! (additional reference if needed: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/pullrequest-submission-and-lifecycle.md#changelog-format)

[anGie44]

Hi @matthewrj , thank you again for submitting this PR 😄 Since our release cadence generally falls on Thursdays, I've pushed up the changes to address the CR comments in addition to some additional refactoring to get everything inline for merging and making it into the upcoming release.

[anGie44]

Output of acceptance tests (commercial):

--- PASS: TestAccAwsDynamoDbKinesisStreamingDestination_disappears (65.38s)
--- PASS: TestAccAwsDynamoDbKinesisStreamingDestination_disappears_DynamoDbTable (66.09s)
--- PASS: TestAccAwsDynamoDbKinesisStreamingDestination_basic (68.61s)

Output of acceptance tests (Gov cloud):

--- SKIP: TestAccAwsDynamoDbKinesisStreamingDestination_disappears (52.20s)
--- SKIP: TestAccAwsDynamoDbKinesisStreamingDestination_disappears_DynamoDbTable (52.21s)
--- SKIP: TestAccAwsDynamoDbKinesisStreamingDestination_basic (52.21s)

[barryoneill]

Thanks @anGie44 !

[ghost]

This has been released in version 3.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.