aws_sqs_queue fifo queues with no name provided do not generate valid queue name.

[steven-schmoll-at]

When creating a fifo sqs queue resource without specifying a name or prefix, the generated name does not have the required .fifo suffix causing AWS to reject the queue creation.

The issue appears to be here: https://github.com/hashicorp/terraform-provider-aws/blob/master/aws/resource_aws_sqs_queue.go#L150

When using name_prefix the .fifo suffix will be appended but not when using a unique id.

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.14.3
+ provider registry.terraform.io/hashicorp/aws v3.22.0
+ provider registry.terraform.io/hashicorp/null v3.0.0
+ provider registry.terraform.io/hashicorp/time v0.6.0
+ provider registry.terraform.io/phillbaker/elasticsearch v1.5.1

Affected Resource(s)

• aws_sqs_queue

Terraform Configuration Files

terraform {
  required_providers {
    aws = {
      source = "hashicorp/aws"
      version = "3.22"
    }
  }
}

provider "aws" {
  region = "ap-southeast-2"
}

resource "aws_sqs_queue" "test_queue" {
  fifo_queue = true
}

Debug Output

Debug Log

Expected Behavior

The queue should have been created with a name such as terraform-20210107023518303200000001.fifo

Actual Behavior

Creation was attempted with the name terraform-20210107023518303200000001 which was rejected by the AWS API.

Steps to Reproduce

Nothing fancy, just use the config above and apply

1. terraform apply

Important Factoids

None

References

[ghost]

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!