r/aws_apigatewayv2_integration: Data mapping in HTTP APIs #17043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/M
DrFaust92
reviewed
Jan 11, 2021
Comment on lines
+348
to
+351
| o, n := d.GetChange("response_parameters") | ||
| os := o.(*schema.Set) | ||
| ns := n.(*schema.Set) | ||
| del := os.Difference(ns).List() |
There was a problem hiding this comment.
I think has go common enough at this point, should we maybe encapsulate it into a function and reuse? or is it too simple?
There was a problem hiding this comment.
Something like we do for diffStringMaps?
For example:
func diffSets(oldSet, newSet *schema.Set) (create, remove, unchanged *schema.Set) {
...
}
Acceptance test output: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Integration_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Integration_ -timeout 120m === RUN TestAccAWSAPIGatewayV2Integration_basicWebSocket === PAUSE TestAccAWSAPIGatewayV2Integration_basicWebSocket === RUN TestAccAWSAPIGatewayV2Integration_basicHttp === PAUSE TestAccAWSAPIGatewayV2Integration_basicHttp === RUN TestAccAWSAPIGatewayV2Integration_disappears === PAUSE TestAccAWSAPIGatewayV2Integration_disappears === RUN TestAccAWSAPIGatewayV2Integration_DataMappingHttp === PAUSE TestAccAWSAPIGatewayV2Integration_DataMappingHttp === RUN TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp === PAUSE TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp === RUN TestAccAWSAPIGatewayV2Integration_LambdaWebSocket === PAUSE TestAccAWSAPIGatewayV2Integration_LambdaWebSocket === RUN TestAccAWSAPIGatewayV2Integration_LambdaHttp === PAUSE TestAccAWSAPIGatewayV2Integration_LambdaHttp === RUN TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket === PAUSE TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket === RUN TestAccAWSAPIGatewayV2Integration_VpcLinkHttp === PAUSE TestAccAWSAPIGatewayV2Integration_VpcLinkHttp === RUN TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration === PAUSE TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration === CONT TestAccAWSAPIGatewayV2Integration_basicWebSocket === CONT TestAccAWSAPIGatewayV2Integration_LambdaHttp === CONT TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration === CONT TestAccAWSAPIGatewayV2Integration_VpcLinkHttp === CONT TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket === CONT TestAccAWSAPIGatewayV2Integration_DataMappingHttp === CONT TestAccAWSAPIGatewayV2Integration_LambdaWebSocket === CONT TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp === CONT TestAccAWSAPIGatewayV2Integration_disappears === CONT TestAccAWSAPIGatewayV2Integration_basicHttp --- PASS: TestAccAWSAPIGatewayV2Integration_disappears (29.08s) --- PASS: TestAccAWSAPIGatewayV2Integration_basicWebSocket (30.68s) --- PASS: TestAccAWSAPIGatewayV2Integration_basicHttp (32.61s) --- PASS: TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp (46.05s) --- PASS: TestAccAWSAPIGatewayV2Integration_DataMappingHttp (48.71s) --- PASS: TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration (48.96s) --- PASS: TestAccAWSAPIGatewayV2Integration_LambdaWebSocket (49.47s) --- PASS: TestAccAWSAPIGatewayV2Integration_LambdaHttp (53.71s) --- PASS: TestAccAWSAPIGatewayV2Integration_VpcLinkHttp (412.36s) --- PASS: TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket (718.91s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 719.017s
ewbankkit
force-pushed
the
f-aws_apigatewayv2_integration-http-api-data-mappings
branch
from
c3df40d to
8aa6d44
Compare
ghost
added
size/L
ewbankkit
changed the title
DrFaust92
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
--- PASS: TestAccAWSAPIGatewayV2Integration_basicWebSocket (57.18s)
--- PASS: TestAccAWSAPIGatewayV2Integration_disappears (57.23s)
--- PASS: TestAccAWSAPIGatewayV2Integration_basicHttp (88.15s)
--- PASS: TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp (92.34s)
--- PASS: TestAccAWSAPIGatewayV2Integration_LambdaHttp (93.68s)
--- PASS: TestAccAWSAPIGatewayV2Integration_LambdaWebSocket (104.58s)
--- PASS: TestAccAWSAPIGatewayV2Integration_DataMappingHttp (113.15s)
--- PASS: TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration (115.05s)
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLinkHttp (417.91s)
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket (786.26s)
|
LGTM 🚀 Thanks @ewbankkit! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Integration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Integration_ -timeout 120m
=== RUN TestAccAWSAPIGatewayV2Integration_basicWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Integration_basicWebSocket
=== RUN TestAccAWSAPIGatewayV2Integration_basicHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_basicHttp
=== RUN TestAccAWSAPIGatewayV2Integration_disappears
=== PAUSE TestAccAWSAPIGatewayV2Integration_disappears
=== RUN TestAccAWSAPIGatewayV2Integration_DataMappingHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_DataMappingHttp
=== RUN TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp
=== RUN TestAccAWSAPIGatewayV2Integration_LambdaWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Integration_LambdaWebSocket
=== RUN TestAccAWSAPIGatewayV2Integration_LambdaHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_LambdaHttp
=== RUN TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket
=== RUN TestAccAWSAPIGatewayV2Integration_VpcLinkHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_VpcLinkHttp
=== RUN TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration
=== PAUSE TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration
=== CONT TestAccAWSAPIGatewayV2Integration_basicWebSocket
=== CONT TestAccAWSAPIGatewayV2Integration_LambdaHttp
=== CONT TestAccAWSAPIGatewayV2Integration_disappears
=== CONT TestAccAWSAPIGatewayV2Integration_DataMappingHttp
=== CONT TestAccAWSAPIGatewayV2Integration_LambdaWebSocket
=== CONT TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp
=== CONT TestAccAWSAPIGatewayV2Integration_basicHttp
=== CONT TestAccAWSAPIGatewayV2Integration_VpcLinkHttp
=== CONT TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration
=== CONT TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket
--- PASS: TestAccAWSAPIGatewayV2Integration_disappears (15.12s)
--- PASS: TestAccAWSAPIGatewayV2Integration_basicWebSocket (17.32s)
--- PASS: TestAccAWSAPIGatewayV2Integration_basicHttp (17.89s)
--- PASS: TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp (27.02s)
--- PASS: TestAccAWSAPIGatewayV2Integration_DataMappingHttp (27.59s)
--- PASS: TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration (29.56s)
--- PASS: TestAccAWSAPIGatewayV2Integration_LambdaHttp (34.02s)
--- PASS: TestAccAWSAPIGatewayV2Integration_LambdaWebSocket (40.61s)
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLinkHttp (293.96s)
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket (677.39s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 679.215sVerified Acceptance Tests in GovCloud (us-gov-west-1) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Integration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Integration_ -timeout 120m
=== RUN TestAccAWSAPIGatewayV2Integration_basicWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Integration_basicWebSocket
=== RUN TestAccAWSAPIGatewayV2Integration_basicHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_basicHttp
=== RUN TestAccAWSAPIGatewayV2Integration_disappears
=== PAUSE TestAccAWSAPIGatewayV2Integration_disappears
=== RUN TestAccAWSAPIGatewayV2Integration_DataMappingHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_DataMappingHttp
=== RUN TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp
=== RUN TestAccAWSAPIGatewayV2Integration_LambdaWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Integration_LambdaWebSocket
=== RUN TestAccAWSAPIGatewayV2Integration_LambdaHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_LambdaHttp
=== RUN TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket
=== PAUSE TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket
=== RUN TestAccAWSAPIGatewayV2Integration_VpcLinkHttp
=== PAUSE TestAccAWSAPIGatewayV2Integration_VpcLinkHttp
=== RUN TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration
=== PAUSE TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration
=== CONT TestAccAWSAPIGatewayV2Integration_basicWebSocket
=== CONT TestAccAWSAPIGatewayV2Integration_LambdaHttp
=== CONT TestAccAWSAPIGatewayV2Integration_DataMappingHttp
=== CONT TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration
=== CONT TestAccAWSAPIGatewayV2Integration_VpcLinkHttp
=== CONT TestAccAWSAPIGatewayV2Integration_LambdaWebSocket
=== CONT TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket
=== CONT TestAccAWSAPIGatewayV2Integration_disappears
=== CONT TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp
=== CONT TestAccAWSAPIGatewayV2Integration_basicHttp
--- PASS: TestAccAWSAPIGatewayV2Integration_disappears (10.72s)
--- PASS: TestAccAWSAPIGatewayV2Integration_basicHttp (11.48s)
--- PASS: TestAccAWSAPIGatewayV2Integration_IntegrationTypeHttp (17.52s)
--- PASS: TestAccAWSAPIGatewayV2Integration_DataMappingHttp (19.67s)
--- PASS: TestAccAWSAPIGatewayV2Integration_LambdaWebSocket (32.03s)
--- PASS: TestAccAWSAPIGatewayV2Integration_basicWebSocket (42.01s)
--- PASS: TestAccAWSAPIGatewayV2Integration_LambdaHttp (44.47s)
--- PASS: TestAccAWSAPIGatewayV2Integration_AwsServiceIntegration (54.64s)
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLinkHttp (319.70s)
--- PASS: TestAccAWSAPIGatewayV2Integration_VpcLinkWebSocket (699.79s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 701.398s |
breathingdust
added a commit
that referenced
this pull request
Jan 14, 2021
ewbankkit
deleted the
f-aws_apigatewayv2_integration-http-api-data-mappings
branch
|
This has been released in version 3.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #17021.
Release note for CHANGELOG:
Output from acceptance testing: