Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tagging support to the aws_dms_certificate resource #17092

Closed
michael-mcguinness opened this issue Jan 13, 2021 · 3 comments · Fixed by #17163
Closed

Add tagging support to the aws_dms_certificate resource #17092

michael-mcguinness opened this issue Jan 13, 2021 · 3 comments · Fixed by #17163
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues.
Milestone
v3.30.0

Comments

@michael-mcguinness
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Tags for DMS Certificates are supported by the Console, CLI and API but not by the aws_dms_certificate resource.

New or Affected Resource(s)

  • aws_dms_certificate
@michael-mcguinness michael-mcguinness added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 13, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 13, 2021
@DrFaust92 DrFaust92 mentioned this issue Jan 13, 2021
Closed
@anGie44 anGie44 added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2021
@snowsky
Copy link
Contributor

snowsky commented Jan 18, 2021

Yesterday I worked with my customer on this issue. Will summarize and submit a PR in a bit.

@snowsky snowsky mentioned this issue Jan 19, 2021
Merged
@anGie44 anGie44 added this to the v3.30.0 milestone Feb 24, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues.
Projects
None yet
Milestone
v3.30.0
Development

Successfully merging a pull request may close this issue.

Add Tags for resource aws_dms_certificate snowsky/terraform-provider-aws
3 participants
@snowsky @anGie44 @michael-mcguinness