Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_lambda_function: prevent read error when fetching code signing config for "Image" package type #17180

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jan 20, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16945

Release note for CHANGELOG:

d/aws_lambda_function: prevent read error when fetching code signing config for "Image" package type

Output from acceptance testing (before code change):

    TestAccDataSourceAWSLambdaFunction_imageConfig: data_source_aws_lambda_function_test.go:191: Step 1/1 error: Error running apply:
        Error: error getting Lambda Function (tf-acc-test-5193479452536870719) Code Signing Config: InvalidParameterValueException: Code signing is not supported for functions created with container images.
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "b2e3bd23-0757-4256-8cce-a16c8be9f167"
          },
          Message_: "Code signing is not supported for functions created with container images.",
          Type: "User"
        }


--- FAIL: TestAccDataSourceAWSLambdaFunction_imageConfig (50.69s)

Output from acceptance testing (after code change):

--- PASS: TestAccDataSourceAWSLambdaFunction_imageConfig (55.20s)

@anGie44 anGie44 requested a review from a team as a code owner January 20, 2021 06:09
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 20, 2021
@anGie44 anGie44 added bug Addresses a defect in current functionality. and removed service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 20, 2021
@bflad bflad added the service/lambda Issues and PRs that pertain to the lambda service. label Jan 20, 2021
@anGie44 anGie44 added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Jan 20, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAWSLambdaFunction_alias (40.84s)
--- PASS: TestAccDataSourceAWSLambdaFunction_basic (40.22s)
--- PASS: TestAccDataSourceAWSLambdaFunction_environment (39.75s)
--- PASS: TestAccDataSourceAWSLambdaFunction_fileSystemConfig (316.92s)
--- PASS: TestAccDataSourceAWSLambdaFunction_layers (35.11s)
--- PASS: TestAccDataSourceAWSLambdaFunction_version (40.83s)
--- PASS: TestAccDataSourceAWSLambdaFunction_vpc (393.54s)
--- SKIP: TestAccDataSourceAWSLambdaFunction_imageConfig (0.71s)

aws/data_source_aws_lambda_function_test.go Show resolved Hide resolved
@ghost ghost added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jan 20, 2021
@anGie44 anGie44 force-pushed the b-lambda-function-data-source-container-img branch from 73c3886 to 1abeba0 Compare January 20, 2021 22:46
@anGie44 anGie44 added this to the v3.25.0 milestone Jan 21, 2021
@anGie44 anGie44 merged commit 5c88a0e into master Jan 21, 2021
@anGie44 anGie44 deleted the b-lambda-function-data-source-container-img branch January 21, 2021 17:33
anGie44 added a commit that referenced this pull request Jan 21, 2021
@ghost
Copy link

ghost commented Jan 22, 2021

This has been released in version 3.25.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data/aws_lambda_function fails to get container image based lambda
2 participants