Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_elasticsearch_domain: Allow setting custom endpoint #17213

Closed
phyrog opened this issue Jan 21, 2021 · 3 comments
Closed

aws_elasticsearch_domain: Allow setting custom endpoint #17213

phyrog opened this issue Jan 21, 2021 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticsearch Issues and PRs that pertain to the elasticsearch service.

Comments

@phyrog
Copy link

phyrog commented Jan 21, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

According to the API docs, elastic search domains support three fields not yet supported by Terraform:

  • DomainEndpointOptions.CustomEndpointEnabled
  • DomainEndpointOptions.CustomEndpoint
  • DomainEndpointOptions.CustomEndpointCertificateArn

These allow users to use a custom endpoint for their elastic search domain instead of the auto-generated one.

New or Affected Resource(s)

  • aws_elasticsearch_domain

Potential Terraform Configuration

resource "aws_elasticsearch_domain" "es" {
  domain_name           = var.domain
  elasticsearch_version = "6.3"

  domain_endpoint_options {
    custom_endpoint_enabled         = true
    custom_endpoint                 = "www.my-custom-endpoint.com"
    custom_endpoint_certificate_arn = "arn:aws:iam::123456789012:certificate/my-certificate"
  }
}

References

@phyrog phyrog added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 21, 2021
@ghost ghost added the service/elasticsearch Issues and PRs that pertain to the elasticsearch service. label Jan 21, 2021
@phyrog phyrog changed the title aws_elastic_search_domain: Allow setting custom endpoint aws_elasticsearch_domain: Allow setting custom endpoint Jan 21, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 21, 2021
@ewbankkit
Copy link
Contributor

@phyrog Thanks for raising this issue.
It has already been noticed in #16059. I'm going to close this one as a duplicate so that we can concentrate discussion in the linked issue.
Please add any additional comments there.

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 21, 2021
@phyrog
Copy link
Author

phyrog commented Jan 21, 2021

Ah for some reason that issue did not show up when I searched for existing issues

@ghost
Copy link

ghost commented Feb 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticsearch Issues and PRs that pertain to the elasticsearch service.
Projects
None yet
Development

No branches or pull requests

2 participants