Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection termination control to AWS LB target group #17227

Closed
austinbutler opened this issue Jan 21, 2021 · 11 comments · Fixed by #21130
Closed

Add connection termination control to AWS LB target group #17227

austinbutler opened this issue Jan 21, 2021 · 11 comments · Fixed by #21130
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Milestone

Comments

@austinbutler
Copy link
Contributor

austinbutler commented Jan 21, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Allow setting deregistration_delay.connection_termination.enabled on aws_lb_target_group.

New or Affected Resource(s)

  • aws_lb_target_group

Potential Terraform Configuration

resource "aws_lb_target_group" "test" {
  name     = "tf-example-lb-tg"
  port     = 80
  protocol = "TCP"
  vpc_id   = aws_vpc.main.id
  connection_termination = true
}
@austinbutler austinbutler added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 21, 2021
@ghost ghost added the service/elbv2 Issues and PRs that pertain to the elbv2 service. label Jan 21, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 21, 2021
@MeisterMasi
Copy link

This new option deregistration_delay.connection_termination.enabled is only for target groups assigned to network load balancers. So in the example configuration the protocol "HTTP" is misleading, better choose protocol "TCP" in the example.

@austinbutler
Copy link
Contributor Author

@MeisterMasi you are right, I just did a quick copy and paste. Edited the request.

@mailtoparveen
Copy link

has it been added ?

@jtjeferreira
Copy link

Although the default value is false, in the AWS UI the recommended value is true...

image

@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 8, 2021
@ayellapurkar
Copy link

Any timeline by when this will be supported ?

@loitho
Copy link
Contributor

loitho commented Oct 3, 2021

Hi,
in the spirit of "be the change you want to see in the world", I proposed a PR for this, feel free to upvote it so it gets prioritized :)
#21130

@smcglincy
Copy link

Should the default value be changed to 'true' to match the AWS UI recommendation?
Please see @jtjeferreira comment

@loitho
Copy link
Contributor

loitho commented Oct 5, 2021

If creating the ressource through the AWS console doesn't set the value to true, I would assume terraform to match this behavior.
Maybe adding a bit more detail in the Terraform documentation to indicate that the option is recommended by AWS to be set to true would be better ?

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@breathingdust breathingdust added this to the Roadmap milestone Nov 10, 2021
@YakDriver YakDriver self-assigned this Nov 22, 2021
@github-actions github-actions bot modified the milestones: Roadmap, v3.68.0 Nov 29, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

This functionality has been released in v3.68.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants