Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_elasticache_replication_group: Enable Multi-AZ #17320

Merged
merged 14 commits into from
Jan 28, 2021
Merged

resource/aws_elasticache_replication_group: Enable Multi-AZ #17320

merged 14 commits into from
Jan 28, 2021

Conversation

gdavison
Copy link
Contributor

Adds multi_az_enabled parameter to aws_elasticache_replication_group and data.aws_elasticache_replication_group. Continues work from #13909.

Closes #13706
Closes #13909

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticacheReplicationGroup_'

--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (94.25s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAz_NoAutomaticFailover (104.94s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (795.49s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (795.94s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1086.04s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup (1086.20s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (1386.47s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (1492.24s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (1704.82s)
--- PASS: TestAccAWSElasticacheReplicationGroup_AutomaticFailover_OneCacheCluster (20.11s)
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (1745.51s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize (1762.82s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown (1802.09s)
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (1851.66s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (1918.09s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (1952.73s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (1138.11s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange (2313.75s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (760.18s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_ReplicasPerNodeGroup (2615.69s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (960.08s)
--- PASS: TestAccAWSElasticacheReplicationGroup_FinalSnapshot (1957.91s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown (2868.56s)
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (1145.14s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic (2873.72s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled (2894.23s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1503.89s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1619.05s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp (2399.82s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster (3328.13s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc (3233.93s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (2467.21s)

@gdavison gdavison requested a review from a team as a code owner January 27, 2021 23:47
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 27, 2021
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 28, 2021
@bflad bflad self-assigned this Jan 28, 2021
bflad
bflad approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSElasticacheReplicationGroup_AutomaticFailover_OneCacheCluster (20.01s)
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (3052.77s)
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (8.38s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (892.20s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup (1895.91s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_ReplicasPerNodeGroup (2156.71s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown (3090.64s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp (2162.47s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (1106.14s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (1571.46s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (2233.23s)
--- PASS: TestAccAWSElasticacheReplicationGroup_FinalSnapshot (969.65s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAz_NoAutomaticFailover (11.54s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1040.30s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc (3440.47s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic (2451.70s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (2091.90s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (2813.04s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster (2098.18s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange (1432.93s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize (1770.79s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown (2128.25s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled (1941.63s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (1586.88s)
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (1131.27s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (1320.22s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (1692.18s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (3760.00s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (855.80s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (680.32s)
--- PASS: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (1235.43s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (1193.20s)

--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_basic (1341.38s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_ClusterMode (1934.11s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_MultiAZ (1341.33s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_NonExistent (10.33s)

Output from acceptance testing in AWS GovCloud (US):

--- FAIL: TestAccAWSElasticacheReplicationGroup_useCmkKmsKeyId (5.75s) # https://github.com/hashicorp/terraform-provider-aws/issues/17224
--- PASS: TestAccAWSElasticacheReplicationGroup_AutomaticFailover_OneCacheCluster (14.95s)
--- PASS: TestAccAWSElasticacheReplicationGroup_basic (1229.69s)
--- PASS: TestAccAWSElasticacheReplicationGroup_clusteringAndCacheNodesCausesError (1.19s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_Basic (1658.16s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_NonClusteredParameterGroup (1025.83s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_ReplicasPerNodeGroup (3731.82s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleDown (3651.13s)
--- PASS: TestAccAWSElasticacheReplicationGroup_ClusterMode_UpdateNumNodeGroups_ScaleUp (2885.67s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAtRestEncryption (675.55s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableAuthTokenTransitEncryption (666.43s)
--- PASS: TestAccAWSElasticacheReplicationGroup_enableSnapshotting (2235.79s)
--- PASS: TestAccAWSElasticacheReplicationGroup_FinalSnapshot (922.58s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAz_NoAutomaticFailover (7.61s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzInVpc (1249.25s)
--- PASS: TestAccAWSElasticacheReplicationGroup_multiAzNotInVpc (2644.06s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Basic (1491.10s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverDisabled (2206.54s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_Failover_AutoFailoverEnabled (1672.64s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_AddMemberCluster (1901.26s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_NoChange (2324.47s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_AtTargetSize (1375.42s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MemberClusterDisappears_RemoveMemberCluster_ScaleDown (1309.83s)
--- PASS: TestAccAWSElasticacheReplicationGroup_NumberCacheClusters_MultiAZEnabled (1601.75s)
--- PASS: TestAccAWSElasticacheReplicationGroup_redisClusterInVpc2 (2011.28s)
--- PASS: TestAccAWSElasticacheReplicationGroup_tags (923.80s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateDescription (1585.88s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateMaintenanceWindow (823.22s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateNodeSize (3044.50s)
--- PASS: TestAccAWSElasticacheReplicationGroup_updateParameterGroup (823.26s)
--- PASS: TestAccAWSElasticacheReplicationGroup_Uppercase (597.76s)
--- PASS: TestAccAWSElasticacheReplicationGroup_vpc (1161.82s)

--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_basic (1671.93s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_ClusterMode (1459.32s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_MultiAZ (865.63s)
--- PASS: TestAccDataSourceAwsElasticacheReplicationGroup_NonExistent (7.87s)

@aashitvyas
Copy link

hi @gdavison @bflad , is there any way to get this merge sooner ?
We are encountering the issue while creating a replication group on AWS Elasticache with Redis.
If this PR gets merge , I can provision Multi AZ cluster without have to do any other workaround.

@gdavison gdavison merged commit 526b579 into main Jan 28, 2021
@gdavison gdavison deleted the elasticache-multi-az branch January 28, 2021 18:19
@github-actions github-actions bot added this to the v3.26.0 milestone Jan 28, 2021
github-actions bot pushed a commit that referenced this pull request Jan 28, 2021
Update CHANGELOG.md for #17320
c52d3a4
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 3.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@mattdrees
Copy link

Thanks much, @gdavison!

@ewbankkit ewbankkit mentioned this pull request Feb 1, 2021
Closed
@markbaird markbaird mentioned this pull request Feb 25, 2021
Closed
@ghost
Copy link

ghost commented Feb 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.26.0
Development

Successfully merging this pull request may close these issues.

Elasticache Redis Multi AZ not enabled
4 participants
@gdavison @aashitvyas @mattdrees @bflad