Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_instance: for inline EBS volumes, throughput is ignored if iops are specified #17379

Closed
matthiasr opened this issue Feb 1, 2021 · 2 comments · Fixed by #17380
Closed
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@matthiasr
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform v0.14.5

  • provider registry.terraform.io/hashicorp/aws v3.25.0
  • provider registry.terraform.io/hashicorp/external v2.0.0
  • provider registry.terraform.io/hashicorp/template v2.2.0

Affected Resource(s)

  • aws_instance resource

Terraform Configuration Files

Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.

provider "aws" {
  region = "eu-west-1"
}

resource "aws_instance" "ebs" {
  count         = 1
  ami           = "ami-043cb8e8f53c04caf"
  instance_type = "t3.micro"
  subnet_id     = "[redacted]"

  root_block_device {
    volume_size = 250
    volume_type = "gp3"

    iops       = 4000
    throughput = 300
  }
}

Debug Output

https://gist.github.com/matthiasr/463670006387c005e78d42910a78f822

Expected Behavior

Root EBS volume has throughput 300

Actual Behavior

EBS volume has throughput 125.

I tested this separately for the ebs_block_device and it shows the same behavior. I believe the ebs_volume resource does not have this issue, but have not extensively tested it as we mostly use inline volumes.

Steps to Reproduce

  1. terraform plan the above HCL
  2. note that the plan says throughput = 300
  3. apply the plan
  4. terraform state show aws_instance.ebs[0] shows throughput = 125 (as does the EC2 console)

Important Factoids

I think I see where this is happening in the code, and will submit a PR shortly.

References

@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Feb 1, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 1, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 2, 2021
@github-actions github-actions bot added this to the v3.28.0 milestone Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
2 participants