Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AthenaEngineVersion option in Athena work groups #17456

Closed
hgalura opened this issue Feb 4, 2021 · 7 comments · Fixed by #17733
Closed

Support for AthenaEngineVersion option in Athena work groups #17456

hgalura opened this issue Feb 4, 2021 · 7 comments · Fixed by #17733
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/athena Issues and PRs that pertain to the athena service.
Milestone

Comments

@hgalura
Copy link

hgalura commented Feb 4, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When defining a work group for Athena, I would like to be able to specify Athena Engine Version.

New or Affected Resource(s)

  • aws_athena_workgroup

Potential Terraform Configuration

References

@hgalura hgalura added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 4, 2021
@ghost ghost added the service/athena Issues and PRs that pertain to the athena service. label Feb 4, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 4, 2021
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Feb 5, 2021
@theophilechevalier
Copy link
Contributor

Hello, any update on this?
It doesn't look like a big deal to merge the proposed MR 👍

@renxunsaky
Copy link

For who is waiting for the feature be available, here is the AWS CLI to update the engine version. After the modification, Terraform will not override this setting since the API used doesn't refer to this property.

for wg in $(aws athena list-work-groups | jq -r '.WorkGroups[].Name')
do
	conf=$(aws athena get-work-group --work-group $wg | jq '.WorkGroup.Configuration | .EngineVersion.SelectedEngineVersion |= "Athena engine version 2" | .EngineVersion.EffectiveEngineVersion |= "Athena engine version 2" | .ResultConfigurationUpdates = .ResultConfiguration | del(.ResultConfiguration)')
	aws athena update-work-group --work-group $wg --configuration-updates $conf
done

@chris922
Copy link
Contributor

chris922 commented Apr 6, 2021

AWS now announced that the Athena engine version 1 will be deprecated in the near future. Thus it would be great to have Terraform support there in advance so that we can at least manually update and verify everything before AWS migrates it automatically to V2.
We've got plenty of workgroups that we don't want to migrate manually and would prefer to use Terraform for this.

Athena engine version 1 will be deprecated in the near future. The exact deprecation date will be announced 90 days in advance in your AWS Personal Health Dashboard. To upgrade your workgroups now, use the Settings page, the Workgroups list page, or the Edit workgroup page of the Athena console. Workgroups not upgraded by the deprecation date will be upgraded to version 2 automatically.

(see the AWS Athena Query editor)

@dimaqq
Copy link

dimaqq commented Jun 30, 2021

AWS automatically upgrades Athena engine version now, it has upgraded the engine version for the workgroup I've created with terraform, and after that tf apply is happy, it doesn't see any changes.
I'd say, this time, we bit the bullet.

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@breathingdust breathingdust added this to the Roadmap milestone Nov 10, 2021
@github-actions github-actions bot modified the milestones: Roadmap, v3.67.0 Nov 23, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/athena Issues and PRs that pertain to the athena service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants