New Data Source: aws_route53_zones

[yuonoda]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17334
Closes #37465

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsRoute53Zones'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsRoute53Zones -timeout 120m
=== RUN   TestAccDataSourceAwsRoute53Zones_basic
=== PAUSE TestAccDataSourceAwsRoute53Zones_basic
=== CONT  TestAccDataSourceAwsRoute53Zones_basic
--- PASS: TestAccDataSourceAwsRoute53Zones_basic (60.97s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       62.732s
...

[hfeixas]

Hey guys, has anyone had a chance to review this ? Would really like to see this feature implemented.

[yuonoda]

@hfeixas Thank you for your comment. Because there are so many pull requests, they shouldn't have time to review this request. So give me 👍 reaction to tell reviewers this feature needs to be implemented.

[antonosmond]

It'd be nice if this took filters e.g. vpc_id.
The AWS CLI has aws route53 list-hosted-zones-by-vpc so it must be possible to get the hosted zones for a given VPC ID and potentially other filters too.

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[freakinhippie]

I know this is a very old PR, but I would like to see it implemented too.

FWIW, in following with the pattern of other recent pluralized data sources, I don't think an empty result set should raise an error, it should just return an empty list.

[yermulnik]

I know this is a very old PR, but I would like to see it implemented too.

Bumping this thread to see whether this feature is feasible yet.

[LukasdeBoer]

This one would be very nice for us too.

[dreinhardt89]

We would like this as well

[DJAlPee]

I have created a new issue without knowing, that this PR already existed: #37465 (Next time, I should search not only the issues, but PRs, too 😉 )

Unfortunately, this PR won't solve my problem directly, because I need the hosted zone names for my case, too. This can be easily achieved by using the aws_route_zone data source with for_each. Ideally, this shouldn't be neccessary, because the list call to AWS provides already a lot of information, which could be used for the resource.

It'd be nice if this took filters e.g. vpc_id. The AWS CLI has aws route53 list-hosted-zones-by-vpc so it must be possible to get the hosted zones for a given VPC ID and potentially other filters too.

With all information provided, it should be possible to filter the results with terraform functions.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53ZonesDataSource_' PKG=route53
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/route53/... -v -count 1 -parallel 20  -run=TestAccRoute53ZonesDataSource_ -timeout 360m
=== RUN   TestAccRoute53ZonesDataSource_basic
=== PAUSE TestAccRoute53ZonesDataSource_basic
=== CONT  TestAccRoute53ZonesDataSource_basic
--- PASS: TestAccRoute53ZonesDataSource_basic (84.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	89.773s

[ewbankkit]

@yuonoda Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.63.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.